-
Notifications
You must be signed in to change notification settings - Fork 121
Jetpack Setup: Update connection step to use APIs where possible #15983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
90468b2
Update connection flow for jetpack setup with application password
itsmeichigo 00b21cc
Update Jetpack connection for flow from login
itsmeichigo 6561866
Update unit tests
itsmeichigo 3b7e4ab
Track connection step only before connection
itsmeichigo 1e49d74
Move connection step to provision
itsmeichigo f7a8e59
Merge branch 'trunk' into woomob-965-jetpack-connection-update
itsmeichigo 8979b80
Fix failed test
itsmeichigo 5fd498a
Remove redundant role check
itsmeichigo 0a6c542
Fix failed test
itsmeichigo 4d5a323
Fix edge case for handling jetpack setup for JCP sites
itsmeichigo a429201
Merge branch 'trunk' into woomob-965-jetpack-connection-update
itsmeichigo 84280fe
Update release notes
itsmeichigo d858645
Fix error due to infinite recursions
itsmeichigo 29929d7
Merge branch 'trunk' into woomob-965-jetpack-connection-update
itsmeichigo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rely on the synthesized initializer in this case? Looks like the manual init does the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to explicitly add this initializer as I need it in
JetpackSetupViewModelTestson the UI layer. The initializer needs to be public to be accessed from outside of the Networking module.