Skip to content

[WCiOS17] Address some CardReader warnings #15998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2025
Merged

[WCiOS17] Address some CardReader warnings #15998

merged 5 commits into from
Aug 11, 2025

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Aug 8, 2025 •
edited
Loading

Part of WOOMOB-1003, but not specifically from iOS17

Description

This PR addresses suppressing warnings around PaymentMethod+Stripe and CardReaderSettingsSearchingViewModel:

  • Stripe has expanded SCPPaymentMethodDetails to accept SCPPaymentMethodTypeWechatPay and SCPPaymentMethodTypeAffirm, which we handle explicitly as unknown since are not supported.
  • CardReaderSettingsSearchingViewModel was not using the result of CardPresentPaymentAction.loadActivePaymentGatewayExtension() which thrown a warning, upon testing I realized that there was a bug with the learn more URL where we were always loading TTP learn more documentation. So we:
    • Update the default to IPP URL: 83a04d2
    • Assign the variable so we provide the correct URL on switching preferred payment method: e5f1ab1

Testing information

  • In Settings > Payments > Payment Provider, select WCPay or Stripe
  • Go to Manage Card Reader and dismiss the connection flow
  • Tap Learn More, and observe the URL for IPP is correct and redirects to the specific payment gateway page
  • Repeat by switching to a different payment provider
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@iamgabrielma
explicitely handle non-supported cases for PaymentMethodDetails
6708739
@iamgabrielma
update default learnMoreURL to use IPP URL
83a04d2
@iamgabrielma
assign unused URL result to learnMoreURL
e5f1ab1 
Since the result of loadActivePaymentGatewayExtension was not being assigned to learnMoreURL, it always showed the default wcpay URL no matter the provider
@iamgabrielma iamgabrielma added this to the 23.1 milestone Aug 8, 2025
@iamgabrielma iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Aug 8, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review August 8, 2025 09:43
@iamgabrielma iamgabrielma requested a review from joshheald August 8, 2025 09:48
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 8, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15998-7516d5d
Version23.0
Bundle IDcom.automattic.alpha.woocommerce
Commit7516d5d
Installation URL6g3qd01nfvpso
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald joshheald self-assigned this Aug 8, 2025
joshheald
joshheald approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks

Base automatically changed from task/ios17-languageCode-deprecation to trunk August 11, 2025 02:29
@iamgabrielma iamgabrielma merged commit 79dead8 into trunk Aug 11, 2025
14 checks passed
@iamgabrielma iamgabrielma deleted the task/ios17-cardreader-warnings branch August 11, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshheald joshheald joshheald approved these changes

Assignees

@joshheald joshheald

Labels

type: task An internally driven task. type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Milestone

23.1

Development

Successfully merging this pull request may close these issues.

4 participants

@iamgabrielma @wpmobilebot @joshheald