[WCiOS17] Update `.onchange()` usage to iOS17 API #16002

iamgabrielma · 2025-08-12T02:51:32Z

Requires bump to iOS17 to be merged first: [WCiOS17] Bump minimum deployment target to iOS17 #16003

Description

This PR addresses ~50 warnings related to the .onChange usage across Order creation and POS, by moving them to use the new iOS17+ API.

The previous API has been updated and deprecated from forcing us to use 1 parameter, to instead:

Use a zero-parameter closure when we don’t care about the value.
Use a two-parameter closure (oldValue, newValue) if we need at least one of them.

All changes are a refactor, so no behavior should be changed. Most of times we either don't care about the value and just react to it, or we care about newValue only.

Testing information

Changes affect multiple files, but superficial smoke testing Order Creation and POS flows should be sufficient, ie:

In the app, create an order, use the product filters, add a coupon, use the stepper to increase/decrease quantity, expand the totals view, process a payment via TTP, send a receipt. Do this via single selection in mobile, and multi-select in tablet.
In POS, setup scanner, go through payment flow, and send a receipt. At some point also move to split view and reduce POS view until is not eligible to use.

Screenshots

N/A

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

dangermattic · 2025-08-12T02:52:03Z

	2 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is assigned to the milestone 23.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

iamgabrielma · 2025-08-12T03:03:56Z

WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/ExpandableBottomSheet.swift

            alwaysVisibleContent()
                .trackSize(size: $fixedContentSize)
-                .onChange(of: fixedContentSize, perform: { [fixedContentSize] _ in
+                .onChange(of: fixedContentSize) {


It doesn't seem we need the capture list here: .onChange(of: fixedContentSize) already re-runs the closure every time fixedContentSize changes, so capturing it when created serves no purpose as it will always have the latest value when the closure runs anyway

iamgabrielma · 2025-08-12T03:06:20Z

WooCommerce/Classes/POS/Presentation/CartView.swift

                    }
-                    .onChange(of: geometry.size.width) {
-                        updateItemImageVisibility(cartListWidth: $0)
+                    .onChange(of: geometry.size.width) { _, newValue in


Passing it implicitly as $0 is no longer something we can do, since we're using the new value inside the closure, we need to be declare it explicitly in .onChange before using it.

Can't you use $1 instead? This is fine though.

Oh, ... that's right 🤦

wpmobilebot · 2025-08-22T09:03:25Z

Version 23.1 has now entered code-freeze, so the milestone of this PR has been updated to 23.2.

# Conflicts: # WooCommerce/Classes/POS/Presentation/Reusable Views/POSModalViewModifier.swift # WooCommerce/Classes/POS/Presentation/Reusable Views/POSSheet.swift

wpmobilebot · 2025-09-03T08:11:50Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr16002-1573804`
	Version	`23.1`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`1573804`
	Installation URL	6bbdq4pg9lddg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

joshheald

Works well. Have you stuck to Peacock's areas only? I see there's still 24 of these warnings not fixed here... that's fine but might be worth a heads up to Kiwi.

WooCommerce
woocommerce-ios/WooCommerce/Classes/Authentication/Jetpack Setup/Native Jetpack Setup/JetpackSetupView.swift
woocommerce-ios/WooCommerce/Classes/Authentication/Jetpack Setup/Native Jetpack Setup/JetpackSetupView.swift:291:10 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/View Modifiers/View+Measurements.swift
woocommerce-ios/WooCommerce/Classes/View Modifiers/View+Measurements.swift:17:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/View Modifiers/View+Measurements.swift:35:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/View Modifiers/View+Measurements.swift:51:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/View Modifiers/View+Measurements.swift:54:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Blaze/AdDestination/BlazeAddParameterView.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Blaze/AdDestination/BlazeAddParameterView.swift:24:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Blaze/AdDestination/BlazeAddParameterView.swift:34:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Blaze/CampaignCreation/BlazeCampaignCreationForm.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Blaze/CampaignCreation/BlazeCampaignCreationForm.swift:225:10 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Blaze/BlazeCampaignList/BlazeCampaignListView.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Blaze/BlazeCampaignList/BlazeCampaignListView.swift:158:10 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Authentication/AccountCreationForm.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Authentication/AccountCreationForm.swift:128:10 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/TopTabView.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/TopTabView.swift:175:46 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/TopTabView.swift:197:30 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/TopTabView.swift:238:34 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/FormattableAmountTextField.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/ReusableViews/SwiftUI Components/FormattableAmountTextField.swift:21:18 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Package and Rate Selection/WooAddCustomPackageView.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Package and Rate Selection/WooAddCustomPackageView.swift:152:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShipping Package and Rate Selection/WooAddCustomPackageView.swift:155:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingAddresses/WooShippingEditAddressView.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingAddresses/WooShippingEditAddressView.swift:88:14 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/WooShipping Create Shipping Labels/WooShippingAddresses/WooShippingEditAddressView.swift:265:22 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductWithAI/StartingInfo/ProductCreationAIStartingInfoView.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductWithAI/StartingInfo/ProductCreationAIStartingInfoView.swift:105:14 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductWithAI/StartingInfo/ProductCreationAIStartingInfoView.swift:109:14 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductWithAI/StartingInfo/PromptProgressBar/ProductCreationAIPromptProgressBar.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductWithAI/StartingInfo/PromptProgressBar/ProductCreationAIPromptProgressBar.swift:32:10 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductWithAI/Preview/ProductDetailPreviewView.swift
woocommerce-ios/WooCommerce/Classes/ViewRelated/Products/Add Product/AddProductWithAI/Preview/ProductDetailPreviewView.swift:137:14 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/POS/Presentation/Reusable Views/POSFullScreenCover.swift
woocommerce-ios/WooCommerce/Classes/POS/Presentation/Reusable Views/POSFullScreenCover.swift:80:14 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

woocommerce-ios/WooCommerce/Classes/POS/Presentation/Reusable Views/POSFullScreenCover.swift:107:14 'onChange(of:perform:)' was deprecated in iOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

iamgabrielma · 2025-09-04T02:58:04Z

Have you stuck to Peacock's areas only? I see there's still 24 of these warnings not fixed here... that's fine but might be worth a heads up to Kiwi.

Yeah, at the moment I loosely split the work in batches around features/files by each team in WOOMOB-1003 so it's easier for testing. Depending on priorities and if they are unable to get to it, then we can do another pass. I'll ping with a reminder to the leads again in any case, as it seems the issue stalls if it doesn't go through proper triage.

iamgabrielma added 4 commits August 12, 2025 09:18

update some onChange instances to iOS17 API

dbeb492

update some POS onChange instances to iOS17 API

826f16d

update onChange API in InfiniteScrollView

d13fe55

update onChange when implicit value was passed to closures

6047761

update release-notes

8f6b925

iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Aug 12, 2025

iamgabrielma added this to the 23.1 milestone Aug 12, 2025

iamgabrielma commented Aug 12, 2025

View reviewed changes

iamgabrielma marked this pull request as ready for review August 12, 2025 03:04

iamgabrielma commented Aug 12, 2025

View reviewed changes

wpmobilebot modified the milestones: 23.1, 23.2 Aug 22, 2025

Merge branch 'trunk' into task/wcios17-updates-to-onchange-v1

1573804

# Conflicts: # WooCommerce/Classes/POS/Presentation/Reusable Views/POSModalViewModifier.swift # WooCommerce/Classes/POS/Presentation/Reusable Views/POSSheet.swift

iamgabrielma requested a review from joshheald September 3, 2025 08:31

joshheald self-assigned this Sep 3, 2025

joshheald approved these changes Sep 3, 2025

View reviewed changes

iamgabrielma merged commit 58c6ebd into trunk Sep 4, 2025
15 checks passed

iamgabrielma deleted the task/wcios17-updates-to-onchange-v1 branch September 4, 2025 02:58

jaclync mentioned this pull request Sep 4, 2025

POS cash payment: prefill order amount and update analytics tracking #16058

Merged

2 tasks

iamgabrielma mentioned this pull request Sep 4, 2025

[WCiOS17] Update .onchange() usage to iOS17 API v2 #16080

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WCiOS17] Update `.onchange()` usage to iOS17 API #16002

[WCiOS17] Update `.onchange()` usage to iOS17 API #16002

Uh oh!

iamgabrielma commented Aug 12, 2025 •

edited

Loading

Uh oh!

dangermattic commented Aug 12, 2025 •

edited

Loading

Uh oh!

iamgabrielma Aug 12, 2025

Uh oh!

iamgabrielma Aug 12, 2025 •

edited

Loading

Uh oh!

joshheald Sep 3, 2025

Uh oh!

iamgabrielma Sep 4, 2025

Uh oh!

wpmobilebot commented Aug 22, 2025

Uh oh!

wpmobilebot commented Sep 3, 2025

Uh oh!

joshheald left a comment

Uh oh!

iamgabrielma commented Sep 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[WCiOS17] Update .onchange() usage to iOS17 API #16002

[WCiOS17] Update .onchange() usage to iOS17 API #16002

Uh oh!

Conversation

iamgabrielma commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

Screenshots

Uh oh!

dangermattic commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamgabrielma Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshheald Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

iamgabrielma Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Aug 22, 2025

Uh oh!

wpmobilebot commented Sep 3, 2025

Uh oh!

joshheald left a comment

Choose a reason for hiding this comment

Uh oh!

iamgabrielma commented Sep 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[WCiOS17] Update `.onchange()` usage to iOS17 API #16002

[WCiOS17] Update `.onchange()` usage to iOS17 API #16002

iamgabrielma commented Aug 12, 2025 •

edited

Loading

dangermattic commented Aug 12, 2025 •

edited

Loading

iamgabrielma Aug 12, 2025 •

edited

Loading