Skip to content

[POS Settings] Update link to barcode scanner docs #16069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2025
Merged

[POS Settings] Update link to barcode scanner docs #16069

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2dbaf9
update link to barcode scanner docs
iamgabrielma Sep 1, 2025
2990f6b
Make POSConstants
iamgabrielma Sep 2, 2025
4bb6fc5
move pointOfSaleDocumentation to POSConstants
iamgabrielma Sep 2, 2025
5a94138
rmeove public access control from enum
iamgabrielma Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WooCommerce/Classes/POS/Presentation/PointOfSaleBarcodeScannerInformationModal.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ struct ProductBarcodeSetupInformation: View {
private var productSetupTextWithLink: AttributedString {
let mainContent = Localization.productBarcodeSetupMessage
let linkText = Localization.productBarcodeSetupLinkText
let link = Constants.detailsLink?.absoluteString ?? ""
let link = Constants.detailsLink.absoluteString

let content = String.localizedStringWithFormat(mainContent, linkText)
var attributedText = AttributedString(content)
Expand All @@ -136,7 +136,7 @@ struct ProductBarcodeSetupInformation: View {
}

private enum Constants {
static let detailsLink = URL(string: "https://woocommerce.com/document/barcode-and-qr-code-scanner/")
static let detailsLink = WooConstants.URLs.pointOfSaleBarcodeScannerDocumentation.asURL()
}

private enum Localization {
Expand Down
2 changes: 1 addition & 1 deletion WooCommerce/Classes/POS/Presentation/Settings/PointOfSaleSettingsHardwareDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ struct PointOfSaleSettingsHardwareDetailView: View {
PointOfSaleBarcodeScannerSetup(isPresented: $showBarcodeScanningSetupModal)
}
.posFullScreenCover(isPresented: $showBarcodeScanningDocumentationModal) {
SafariView(url: WooConstants.URLs.pointOfSaleDocumentation.asURL())
SafariView(url: WooConstants.URLs.pointOfSaleBarcodeScannerDocumentation.asURL())
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions WooCommerce/Classes/System/WooConstants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,10 @@ extension WooConstants {
///
case pointOfSaleDocumentation = "https://woocommerce.com/document/woo-mobile-app-point-of-sale-mode/"

/// URL for Point of Sale's barcode scanner documentation
///
case pointOfSaleBarcodeScannerDocumentation = "https://woocommerce.com/document/barcode-and-qr-code-scanner/"
Copy link
Contributor

@jaclync jaclync Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: from Povilas's effort to modularize POS, I wonder if we could separate the POS constants so that the POS code isn't dependent on the constants enums that are mostly used in the store management part of the app.

Copy link
Contributor Author

@iamgabrielma iamgabrielma Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out, I've made a POSConstants on 2990f6b which copies the current usage of WooConstants, and moved the 2 documentation links we use for settings along with 4bb6fc5

Most likely we'll want to copy over as well the links regarding IPP, but I'll leave it out for the moment.


/// Temporary redirect URL for authenticated web view when authenticating WPCom automatically
///
case wpcomTempRedirectURL = "https://wordpress.com/mobile-redirect"
Expand Down