[Woo POS] Fix two failing analytics tests

[joshheald]

Description

When I run tests locally, sendReceipt_tracks_failure_with_eligible_for_pos_receipt and sendReceipt_tracks_success_with_eligible_for_pos_receipt would always fail on the check for #expect(analyticsProvider.receivedProperties[indexOfEvent]["eligible_for_pos_receipt”] == {value}).

It’s using index 1, because index 0 was an order_created event, which has no properties. That meant that the arrays for properties and events didn’t line up.

When we expected index 1, the tests crashed because of the index being out of range.

I don’t know yet why these aren’t blocking CI.

To fix it, we simply reset the saved events before the When in each test.

I also stopped the order tests from making the cha-ching sound

Steps to reproduce

1. Run PointOfSaleOrderControllerTests locally
2. Observe that all tests complete and pass.

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	pr16083-b1ca363
	Version	23.2
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	b1ca363
	Installation URL	43lgphbq3opl8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[joshheald]

Here's some output from CI's unit tests from before the fix, taken from this run:

2025-09-04 12:27:14 BST
[04:27:14]: ▸ Failing tests:
[04:27:14]: ▸ 	AnalyticsTests.startCashPayment_when_invoked_tracks_expected_event()
[04:27:14]: ▸ 	AnalyticsTests.sendReceipt_tracks_success_with_eligible_for_pos_receipt()
[04:27:14]: ▸ 	AnalyticsTests.sendReceipt_tracks_failure_with_eligible_for_pos_receipt()
[04:27:14]: ▸ ** TEST EXECUTE FAILED **

And then a little further down

2025-09-04 12:27:19 BST
Failing tests:
	AnalyticsTests.startCashPayment_when_invoked_tracks_expected_event()
	AnalyticsTests.sendReceipt_tracks_success_with_eligible_for_pos_receipt()
	AnalyticsTests.sendReceipt_tracks_failure_with_eligible_for_pos_receipt()
** TEST EXECUTE FAILED **
[04:27:19]: Exit status: 65
+--------------------------------------------------+
|                   Test Results                   |
+-------------------------+------------------------+
| Number of tests         | 9432 (and 197 retries) |
| Number of tests skipped | 10                     |
| Number of failures      | 0                      |
+-------------------------+------------------------+
[04:27:20]: Test execution failed. Exit status: 65

So it seems like the TEST EXECUTE FAILED wasn't enough to mark the job as failed, because even though it spotted 3 failures, none of them ended up in the count in the table... which is interesting.

[joshheald]

And even with the fix, making the tests pass locally, they still fail on CI. It just doesn't mark the tests as failed.

[05:11:11]: ▸     ✔ collectCashPayment_when_failure_tracks_correct_event() (0.001 seconds)
[05:11:11]: ▸     ⚠️  Test sendReceipt_tracks_success_with_eligible_for_pos_receipt() recorded an issue at PointOfSaleOrderControllerTests.swift:648:13: Expectation failed: (analyticsProvider.receivedProperties[indexOfEvent]["eligible_for_pos_receipt"] as? Bool → false) == true
[05:11:11]: ▸     ✖ sendReceipt_tracks_success_with_eligible_for_pos_receipt() (0.001 seconds) 1 issue(s)
[05:11:11]: ▸     ✔ sendReceipt_without_order_tracks_failure_without_eligible_for_pos_receipt() (0.001 seconds)
[05:11:11]: ▸     ⚠️  Test sendReceipt_tracks_failure_with_eligible_for_pos_receipt() recorded an issue at PointOfSaleOrderControllerTests.swift:695:17: Expectation failed: (analyticsProvider.receivedProperties[indexOfEvent]["eligible_for_pos_receipt"] as? Bool → false) == true
[05:11:11]: ▸     ✖ sendReceipt_tracks_failure_with_eligible_for_pos_receipt() (0.003 seconds) 1 issue(s)
[...]
[05:13:28]: ▸ Failing tests:
[05:13:28]: ▸ 	AnalyticsTests.startCashPayment_when_invoked_tracks_expected_event()
[05:13:28]: ▸ 	AnalyticsTests.sendReceipt_tracks_success_with_eligible_for_pos_receipt()
[05:13:28]: ▸ 	AnalyticsTests.sendReceipt_tracks_failure_with_eligible_for_pos_receipt()
[05:13:28]: ▸ 	AlamofireNetworkTests.test_concurrent_requests_fail_with_sessionDeinitialized_error_when_ensuresSessionManagerIsInitialized_is_false()
[05:13:28]: ▸ ** TEST EXECUTE FAILED **

[joshheald]

Only one review needed. Nothe that this comes before #16088 – that's where I've fixed the CI reporting of the tests.

[wpmobilebot]

Version 23.2 has now entered code-freeze, so the milestone of this PR has been updated to 23.3.

[jaclync]

Thanks for taking a look and disabling the cha-ching sound! Feel free to merge after checking if CI passes after the suggested changes.