-
Notifications
You must be signed in to change notification settings - Fork 121
Update gems to fix CI reporting of Swift Testing failures #16088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshheald
merged 12 commits into
task/fix-receipt-eligibility-analytics-test
from
task/update-gems-to-report-swifttesting-failures
Sep 5, 2025
Merged
Update gems to fix CI reporting of Swift Testing failures #16088
joshheald
merged 12 commits into
task/fix-receipt-eligibility-analytics-test
from
task/update-gems-to-report-swifttesting-failures
Sep 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
1 task
Contributor
Author
|
Only one review needed |
staskus
approved these changes
Sep 4, 2025
Contributor
staskus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Good to know that it's solved.
…update-gems-to-report-swifttesting-failures
b1ca363
into
task/fix-receipt-eligibility-analytics-test
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Merge after: #16083
Description
CI was not marking SwiftTesting test failures as failures in the unit test job. This is solved by an update to the
trainerdependency of fastlane, which can handle the new format of .xctestresult that contains Swift Testing results.trainercontinues to convert these to JUnit results and uploads them to the Test Engine.We previously used fastlane 2.217. This PR updates us to 2.228, which includes the new
trainerdependency.See p1756990479360729-slack-CC7L49W13 for discussion/context
This PR also fixes some failing tests which were previously non-blocking, due to being written with SwiftTesting.
Steps to reproduce
Here's the tests failing from a previous commit
RELEASE-NOTES.txtif necessary.