Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Sep 4, 2025

Merge after: #16083

Description

CI was not marking SwiftTesting test failures as failures in the unit test job. This is solved by an update to the trainer dependency of fastlane, which can handle the new format of .xctestresult that contains Swift Testing results. trainer continues to convert these to JUnit results and uploads them to the Test Engine.

We previously used fastlane 2.217. This PR updates us to 2.228, which includes the new trainer dependency.

See p1756990479360729-slack-CC7L49W13 for discussion/context

This PR also fixes some failing tests which were previously non-blocking, due to being written with SwiftTesting.

Steps to reproduce

  1. Add a failing SwiftTesting test to a branch off this one
  2. Push it to Github to run CI
  3. Observe that the failing test blocks the merge.

Here's the tests failing from a previous commit


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added this to the 23.3 milestone Sep 4, 2025
@joshheald joshheald added the type: task An internally driven task. label Sep 4, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 4, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16088-178b11f
Version23.2
Bundle IDcom.automattic.alpha.woocommerce
Commit178b11f
Installation URL4c2gcptrhrnjo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@joshheald
Copy link
Contributor Author

Only one review needed

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Good to know that it's solved.

@joshheald joshheald merged commit b1ca363 into task/fix-receipt-eligibility-analytics-test Sep 5, 2025
14 checks passed
@joshheald joshheald deleted the task/update-gems-to-report-swifttesting-failures branch September 5, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants