-
Notifications
You must be signed in to change notification settings - Fork 121
Make Application Passwords toggle visible only for WP.com authenticated users #16086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Application Passwords toggle visible only for WP.com authenticated users #16086
Conversation
|
|
|
Version |
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great, code changes look good too 👍
| //For now rely on local FF for mocked value to avoid unwanted exposure | ||
| let mockResultValue = ServiceLocator.featureFlagService.isFeatureFlagEnabled( | ||
| .applicationPasswordExperiment | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsmeichigo I'm gonna re-create this PR and target the beta. Otherwise the feature toggle will be visible to users. There is no remote FF yet integrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I missed that. You can merge this PR and create a PR targeting beta with only the replacement of the mock result for simplicity. When merging back to trunk, the change will not cause any conflict because it's identical with trunk.

WOOMOB-1189
Description
Follows the suggestion and adds
!stores.isAuthenticatedWithoutWPComas a part of experiment feature availability condition. The toggle should be shown only when the user is signed in using WordPress.com account.Testing steps
Testing info
Tested on iOS 18.4 simulator and team shared testing store.
Screenshots
N/A
RELEASE-NOTES.txtif necessary.