-
Notifications
You must be signed in to change notification settings - Fork 121
Make Application Passwords toggle visible only for WP.com authenticated users #16086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RafaelKayumov
merged 4 commits into
trunk
from
WOOMOB-1189-additinal-feature-availability-checks
Sep 5, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b3eee04
Use local FF as temp condition for feature visibility
RafaelKayumov 388107b
Use WP.com authentication as condition for App Passwords experiment e…
RafaelKayumov 390b735
Update tests
RafaelKayumov bd7276a
Add ApplicationPasswordsExperimentAvailabilityCheckerTests
RafaelKayumov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
...ceTests/ViewRelated/Settings/ApplicationPasswordsExperimentAvailabilityCheckerTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import XCTest | ||
| import Yosemite | ||
| @testable import WooCommerce | ||
|
|
||
| final class ApplicationPasswordsExperimentAvailabilityCheckerTests: XCTestCase { | ||
| private var availabilityChecker: ApplicationPasswordsExperimentAvailabilityCheckerProtocol! | ||
| private var stores: StoresManager! | ||
| private var userDefaults: UserDefaults! | ||
|
|
||
| override func tearDown() { | ||
| availabilityChecker = nil | ||
| stores = nil | ||
| userDefaults = nil | ||
| super.tearDown() | ||
| } | ||
|
|
||
| private func setupEnvironment( | ||
| isWPComAuthenticated: Bool, | ||
| isRemoteFFEnabled: Bool | ||
| ) throws { | ||
| stores = MockStoresManager( | ||
| sessionManager: .makeForTesting( | ||
| authenticated: true, | ||
| isWPCom: isWPComAuthenticated | ||
| ) | ||
| ) | ||
|
|
||
| userDefaults = try XCTUnwrap(UserDefaults(suiteName: "TestingSuite")) | ||
| userDefaults[.applicationPasswordsExperimentRemoteFFValue] = isRemoteFFEnabled | ||
|
|
||
| availabilityChecker = ApplicationPasswordsExperimentAvailabilityChecker( | ||
| userDefaults: userDefaults, | ||
| stores: stores | ||
| ) | ||
| } | ||
|
|
||
| func test_when_wpcom_authenticated_and_remote_ff_enabled_then_isAvailable_returns_true() throws { | ||
| try setupEnvironment(isWPComAuthenticated: true, isRemoteFFEnabled: true) | ||
| XCTAssertTrue(availabilityChecker.isAvailable) | ||
| } | ||
|
|
||
| func test_when_wpcom_authenticated_and_remote_ff_disabled_then_isAvailable_returns_false() throws { | ||
| try setupEnvironment(isWPComAuthenticated: true, isRemoteFFEnabled: false) | ||
| XCTAssertFalse(availabilityChecker.isAvailable) | ||
| } | ||
|
|
||
| func test_when_not_wpcom_authenticated_and_remote_ff_enabled_then_isAvailable_returns_false() throws { | ||
| try setupEnvironment(isWPComAuthenticated: false, isRemoteFFEnabled: true) | ||
| XCTAssertFalse(availabilityChecker.isAvailable) | ||
| } | ||
|
|
||
| func test_when_not_wpcom_authenticated_and_remote_ff_disabled_then_isAvailable_returns_false() throws { | ||
| try setupEnvironment(isWPComAuthenticated: false, isRemoteFFEnabled: false) | ||
| XCTAssertFalse(availabilityChecker.isAvailable) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsmeichigo I'm gonna re-create this PR and target the beta. Otherwise the feature toggle will be visible to users. There is no remote FF yet integrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I missed that. You can merge this PR and create a PR targeting beta with only the replacement of the mock result for simplicity. When merging back to trunk, the change will not cause any conflict because it's identical with trunk.