-
Notifications
You must be signed in to change notification settings - Fork 121
[Local Catalog] POS Settings: integrate with catalog data and full sync functionality #16144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s a range due to different precision in database.
|
|
…essing `ServiceLocator.grdbManager` when the feature flag is disabled.
|
Hi @joshheald no rush reviewing this PR, or just leave initial comments first on a high level review if you get a chance. I will try breaking it into two PRs if you will be reviewing it later. |
# Conflicts: # WooCommerce/Classes/POS/Utils/PreviewHelpers.swift
…ase call is made.
…OOMOB-1100-pos-sync-settings-basic
joshheald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great, thanks for doing this.
I found that when I switched stores, the old numbers were used. I can't immediately see why, but it only happened if I was quick to open POS, and corrected itself after closing and re-opening POS. So there's some state sticking around between launches. The sync coordinator is suspect here, because it's held on the service locator... but it shouldn't really play a part in getting the numbers, so perhaps there's something else that's not reset when it should be.
Also, we use "Last incremental update" and "Last full sync" as titles, which is inconsistent. I think it would stand out less if we just said "Last update", which is clearer anyway, or "Last incremental sync", though I like that less.
I noticed this issue during testing as well, it was from a recent CIAB change p1758613264239289/1758605672.214159-slack-CGPNUU63E. Kiwi had a workaround p1758690950124649/1758605672.214159-slack-CGPNUU63E and I had a PR #16173 that refactors this part. I will merge after testing with the latest trunk merged in. |
If I understood correctly, I made the following copy changes to show "sync" instead of "sync" in the UI:
Along with other changes to use "update" for consistency in aba8530. We don't have a design for the settings yet, can make more copy/UI updates later.
|


Part of WOOMOB-1100
Please review #16166 first, or together.
Description
This PR integrates the settings UI with catalog stats & sync functionality. The implementation includes:
Steps to reproduce
Refresh catalogto start a full sync --> the spinner should be shown in the button. for a site with a small catalog, it should be rather quick. the catalog size & last full sync date should be updated after the sync completesTesting information
I tested on a small site, and a large site and left the settings while the full sync was still ongoing.
Screenshots
Latest copy:
Simulator.Screen.Recording.-.iPad.A16.-.2025-09-18.at.16.29.12.mov
RELEASE-NOTES.txtif necessary.