Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Oct 1, 2025

Part of: WOOMOB-1236

Description

In this PR the work on the "Booking details" is continued. Previous PR: [Bookings][Part 2] Booking details screen.

  • Added a navigation from booking list to a booking details view
  • Added booking details navigation header: back action, booking id title, ellipsis item(not handled).
  • Updated appointment duration formatting to present user friendly hour and minute units
  • Updated price formatting for appointment details and payments section that accounts store currency settings.

Testing steps

  • Use CIAB store with existing bookings
  • Navigate to bookings list
  • Tap on a booking
  • Make sure the booking details screen is opened
  • Check that header title contains correct booking id (Use Xcode debug mode to asses Booking model id).
  • In "Appointment details" section make sure the date, time interval, duration and price reflect values from Booking model.
  • Make sure that formatted price from appointment details section has the same currency as the store
  • Make sure that formatted prices from Payment section have the same currency as the store

Testing information

The above steps are tested on iOS 26 iPhone 17 simulator.

Screenshots

Header
image
Before After
image image

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.4 milestone Oct 1, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Oct 1, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 23.4. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 1, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16191-ea110ea
Version23.3
Bundle IDcom.automattic.alpha.woocommerce
Commitea110ea
Installation URL71k3ep86s41ro
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data looks good to me. Regarding the navigation, I set up the BookingsTabView to contain a split view to be consistent with Orders and Products tabs. The idea is to display the list on the left and selected detail on the right for iPad, while on the phone the view is collapsed. Is it possible to update the navigation here?

@itsmeichigo
Copy link
Contributor

Correction - according to recent updates in Slack threads, we might want to revise the currency and timezone used for formatting the cost and time. Please feel free to address those in a separate PR.

# Conflicts:
#	WooCommerce/Classes/Bookings/BookingList/BookingListView.swift
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack there seems to be an issue with the split view on the BookingsTabView, so I'm approving to unblock this PR. Let's fix the split view in a different PR.

@RafaelKayumov RafaelKayumov merged commit 231a013 into trunk Oct 2, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1236-booking-details-part-3 branch October 2, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants