-
Notifications
You must be signed in to change notification settings - Fork 121
[Bookings][Part 3] Booking details screen #16191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data looks good to me. Regarding the navigation, I set up the BookingsTabView to contain a split view to be consistent with Orders and Products tabs. The idea is to display the list on the left and selected detail on the right for iPad, while on the phone the view is collapsed. Is it possible to update the navigation here?
|
Correction - according to recent updates in Slack threads, we might want to revise the currency and timezone used for formatting the cost and time. Please feel free to address those in a separate PR. |
# Conflicts: # WooCommerce/Classes/Bookings/BookingList/BookingListView.swift
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in Slack there seems to be an issue with the split view on the BookingsTabView, so I'm approving to unblock this PR. Let's fix the split view in a different PR.

Part of: WOOMOB-1236
Description
In this PR the work on the "Booking details" is continued. Previous PR: [Bookings][Part 2] Booking details screen.
Testing steps
Testing information
The above steps are tested on iOS 26 iPhone 17 simulator.
Screenshots
RELEASE-NOTES.txtif necessary.