Skip to content

Fix warning about offline banner on dashboard #16347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
Merged

Fix warning about offline banner on dashboard #16347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91cd201
Add offline banner to dashboard manually
itsmeichigo Nov 12, 2025
7662fa5
Update release notes
itsmeichigo Nov 12, 2025
9f2124c
Merge branch 'trunk' into woomob-1679-offlinebannerview-on-dashboard
itsmeichigo Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [*] Fix order details presentation when opened from booking details [https://github.com/woocommerce/woocommerce-ios/pull/16331]
- [*] Show POS feedback surveys for eligible merchants [https://github.com/woocommerce/woocommerce-ios/pull/16325]
- [*] Fix product variation selection for order creation [https://github.com/woocommerce/woocommerce-ios/pull/16317]
- [Internal] Fix warning when displaying offline banner on My Store [https://github.com/woocommerce/woocommerce-ios/pull/16347]
- [Internal] Notify listeners immediately after updating predicates or sort descriptors for results controllers. [https://github.com/woocommerce/woocommerce-ios/pull/16350]

23.6
Expand Down
4 changes: 4 additions & 0 deletions WooCommerce/Classes/ViewRelated/Dashboard/DashboardView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ struct DashboardView: View {

storePlanBanner
.renderedIf(connectivityStatus != .notReachable)

OfflineBannerViewRepresentable()
.frame(height: OfflineBannerView.height)
.renderedIf(connectivityStatus == .notReachable)
}
.sheet(isPresented: $showingSupportForm) {
supportForm
Expand Down
4 changes: 0 additions & 4 deletions WooCommerce/Classes/ViewRelated/Dashboard/DashboardViewHostingController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ final class DashboardViewHostingController: UIHostingController<DashboardView> {
await viewModel.reloadAllData()
}
}

override var shouldShowOfflineBanner: Bool {
return true
}
}

// MARK: Private helpers
Expand Down