Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Nov 12, 2025

Closes WOOMOB-1679

Description

When a device goes offline, we're showing offline banner on views that show cached data. Since iOS 26, we got a warning when showing the offline banner through navigation controller delegate to hosting controller of SwiftUI views:

This PR fixes this issue on the dashboard (My Store tab) by removing the shouldShowOfflineBanner computed variable from the hosting controller and add the offline banner to the SwiftUI view manually instead.

Test Steps

  • Since network detection does not work properly on simulator, please build and run the app on a physical device instead.
  • Disconnect the Internet connection.
  • Confirm that the offline banner is displayed on the My Store screen.
  • Confirm that there's no warning about the banner in Xcode.

Screenshots

IMG_9097
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.7 milestone Nov 12, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 12, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.7. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@itsmeichigo itsmeichigo marked this pull request as ready for review November 12, 2025 09:51
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 12, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16347-9f2124c
Version23.6
Bundle IDcom.automattic.alpha.woocommerce
Commit9f2124c
Installation URL1s0g5e003tpq0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo merged commit d04c772 into trunk Nov 14, 2025
14 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1679-offlinebannerview-on-dashboard branch November 14, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants