Skip to content

Conversation

@ealeksandrov
Copy link
Contributor

Part of: #7863

Description

This PR adds custom SiriKit intent to use for widgets configuration.
PR targets temporary feature branch, because it's complicated to hide custom intent behind feature flag.

Testing

  1. Add a widget to home screen (long press on home screen > tap + in top left > search for Woo).
  2. Configure Widget (long press on widget > tap "Edit Widget").
  3. Confirm that "Time Range" setting is available with 4 correct options (same as stats dashboard in the app).

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ealeksandrov ealeksandrov added the feature: widgets iOS Homescreen widgets label Oct 17, 2022
@ealeksandrov ealeksandrov added this to the 10.9 milestone Oct 17, 2022
@ealeksandrov ealeksandrov marked this pull request as draft October 18, 2022 14:22
@ealeksandrov ealeksandrov force-pushed the issue/7863-widgets-configuration-custom-intent branch from a487ca0 to a9094a4 Compare October 18, 2022 15:00
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr7872-a9094a4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ealeksandrov ealeksandrov marked this pull request as ready for review October 18, 2022 16:45
@ealeksandrov
Copy link
Contributor Author

Noticed CI issue and force-pushed the fix to remove Yosemite dependency from widgets target.

Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I wonder if there is a way to make the current widgets default to today, so the merchants don't have to edit them by themselves.

Screen Shot 2022-10-19 at 4 43 19 PM

@ealeksandrov
Copy link
Contributor Author

Thanks for review!

make the current widgets default to today

You describe widgets migration from previous version? It may be complicated to control from our side.
I'll add it as a note to parent issue. I'm merging PR to feature branch, so it won't be delivered to users until we finish.

@ealeksandrov ealeksandrov merged commit fddbce0 into issue/7863-widgets-configuration Oct 20, 2022
@ealeksandrov ealeksandrov deleted the issue/7863-widgets-configuration-custom-intent branch October 20, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: widgets iOS Homescreen widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants