Skip to content

[Tooling] Make Codegen module aware #7970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 2, 2022
Merged

[Tooling] Make Codegen module aware #7970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
666249f
Update templates to include Module names in specs
joshheald Oct 28, 2022
b9eef45
Regenerate code adding module names
joshheald Oct 28, 2022
cf3cfe2
Rename YosemiteJITM to use module-aware fakes
joshheald Oct 28, 2022
1720c02
Fix filename of Yosemite.JustInTimeMessage
joshheald Oct 28, 2022
df0d3db
Remove unneccesary `Yosemite.` within same module
joshheald Oct 28, 2022
d16587f
Merge branch 'trunk' into task/make-codegen-module-aware
joshheald Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CodeGeneration/Sourcery/Copiable/Models+Copiable.swifttemplate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ let specsToGenerate: [CopiableSpec] = matchingTypes.map { type in
}

return CopiableSpec(
name: type.name,
name: type.globalName,
accessLevelWithSpacePostfix: type.accessLevel == "internal" ? "" : "\(type.accessLevel) ",
properties: propSpecs
)
Expand Down
2 changes: 1 addition & 1 deletion CodeGeneration/Sourcery/Fakes/Fakes.swifttemplate
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ let specsToGenerate: [FakeableSpec] = matchingTypes.map { type in
)
}

return FakeableSpec(name: type.name, accessLevelWithSpacePostfix: accessLevel, content: .initializer(propSpecs))
return FakeableSpec(name: type.globalName, accessLevelWithSpacePostfix: accessLevel, content: .initializer(propSpecs))
}
-%>
<%#
Expand Down
16 changes: 8 additions & 8 deletions Fakes/Fakes/Hardware.generated.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ extension CardBrand {
.visa
}
}
extension CardPresentReceiptParameters {
extension Hardware.CardPresentReceiptParameters {
/// Returns a "ready to use" type filled with fake values.
///
public static func fake() -> CardPresentReceiptParameters {
public static func fake() -> Hardware.CardPresentReceiptParameters {
.init(
amount: .fake(),
formattedAmount: .fake(),
Expand All @@ -27,10 +27,10 @@ extension CardPresentReceiptParameters {
)
}
}
extension CardPresentTransactionDetails {
extension Hardware.CardPresentTransactionDetails {
/// Returns a "ready to use" type filled with fake values.
///
public static func fake() -> CardPresentTransactionDetails {
public static func fake() -> Hardware.CardPresentTransactionDetails {
.init(
last4: .fake(),
expMonth: .fake(),
Expand All @@ -44,10 +44,10 @@ extension CardPresentTransactionDetails {
)
}
}
extension Charge {
extension Hardware.Charge {
/// Returns a "ready to use" type filled with fake values.
///
public static func fake() -> Charge {
public static func fake() -> Hardware.Charge {
.init(
id: .fake(),
amount: .fake(),
Expand All @@ -66,10 +66,10 @@ extension ChargeStatus {
.succeeded
}
}
extension PaymentIntent {
extension Hardware.PaymentIntent {
/// Returns a "ready to use" type filled with fake values.
///
public static func fake() -> PaymentIntent {
public static func fake() -> Hardware.PaymentIntent {
.init(
id: .fake(),
status: .fake(),
Expand Down
Loading