-
Notifications
You must be signed in to change notification settings - Fork 121
Add IPP plugin status tags to ZenDesk #8008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f9863b7
Add getPluginDetails action to ZendeskManager
iamgabrielma a38b305
Add plugin list and completion handler callback
iamgabrielma f44fca0
Try to get plugins by observing changes in Storage
iamgabrielma 783e34a
Append ipp tags if needed to decorated tags
iamgabrielma 914d74b
Add logic for plugin status
iamgabrielma 1c97557
Experiment with async call for tag retrieval
iamgabrielma 7a3b9ce
Return all tags on creating ZD request
iamgabrielma 6f9a3fd
Remove unused vars
iamgabrielma 4b39882
Move plugin slugs to Constants enum
iamgabrielma 75cb967
Access control changes. Make func private.
iamgabrielma e243aaa
Extract logic to SettingsViewModel
iamgabrielma b59a59d
Rename variables for clarity. Add comments.
iamgabrielma 96b123d
Move logic to ZendeskManager
iamgabrielma 9a1ae44
Remove unnecessary variable
iamgabrielma 849862e
Remove unused extension from SettingsViewModel
iamgabrielma 10fcac6
Make enum cases snakecase and split them
iamgabrielma c364689
Make ippPluginstatuses non-optional
iamgabrielma 16affe8
Fix opening brace violation
iamgabrielma 37b95b5
Move ResultsController outside of ZendeskManager init
iamgabrielma f82b2c9
Access ZD shared from SwitchStore
iamgabrielma e88a7a3
Make pluginResultsController lazy
iamgabrielma dca42e5
Add missing method to MockZendeskManager
iamgabrielma 9984996
Rename method for clarity. Typo.
iamgabrielma d341fc5
Remove trailing whitespace
iamgabrielma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.