Centralize WordPressKit pod definition in Podfile
#8050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
commented
Nov 7, 2022
Comment on lines
+37
to
+39
| # To allow pod to pick up beta versions use -beta. E.g., 1.1.7-beta.1 | ||
| pod 'WordPressKit', '~> 4.49.0' | ||
| # pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => '' |
Contributor
Author
There was a problem hiding this comment.
I have opinions on how to define this but I'll leave them for a dedicated PR later on.
mokagio
force-pushed
the
mokagio/centralize-wpkit-podfile
branch
from
3427e0a to
20ab06e
Compare
Collaborator
You can test the changes from this Pull Request by:
|
mokagio
added
the
category: tooling
AliSoftware
approved these changes
Nov 7, 2022
Contributor
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
Looks like a no-brainer to me 👍 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What it says in the title. Just a minor tidy up opportunity I noticed.
Testing instructions
If CI builds and doesn't warn us about
Podfile.lockinconsistencies, we're good.RELEASE-NOTES.txtif necessary.