Skip to content

Centralize WordPressKit pod definition in Podfile #8050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
+9 −8
Merged

Centralize WordPressKit pod definition in Podfile #8050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ def tracks
# pod 'Automattic-Tracks-iOS', :path => '../Automattic-Tracks-iOS'
end

def wordpress_kit
# To allow pod to pick up beta versions use -beta. E.g., 1.1.7-beta.1
pod 'WordPressKit', '~> 4.49.0'
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => ''
Comment on lines +37 to +39
Copy link
Contributor Author

@mokagio mokagio Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opinions on how to define this but I'll leave them for a dedicated PR later on.

end

def keychain
pod 'KeychainAccess', '~> 4.2.2'
end
Expand Down Expand Up @@ -115,10 +121,7 @@ def yosemite_pods
alamofire
stripe_terminal
cocoa_lumberjack

# To allow pod to pick up beta versions use -beta. E.g., 1.1.7-beta.1
pod 'WordPressKit', '~> 4.49.0'
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => ''
wordpress_kit

aztec
end
Expand Down Expand Up @@ -174,9 +177,7 @@ def networking_pods
# Used for HTML parsing
aztec

# To allow pod to pick up beta versions use -beta. E.g., 1.1.7-beta.1
pod 'WordPressKit', '~> 4.49.0'
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => ''
wordpress_kit
end

# Networking Target:
Expand Down
2 changes: 1 addition & 1 deletion Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,6 @@ SPEC CHECKSUMS:
ZendeskSupportProvidersSDK: 2bdf8544f7cd0fd4c002546f5704b813845beb2a
ZendeskSupportSDK: 3a8e508ab1d9dd22dc038df6c694466414e037ba

PODFILE CHECKSUM: 3b1ba1b6abc1062da9355f08123c1118559edf9c
PODFILE CHECKSUM: 55531c64b396f477ea6e3814ab400e9b14d0bf48

COCOAPODS: 1.11.3