Skip to content

Products Onboarding: Add product_detail_preview_tapped event #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2022
Merged

Products Onboarding: Add product_detail_preview_tapped event #8070

merged 2 commits into from
Nov 10, 2022

Conversation

@ealeksandrov
Copy link
Contributor

@ealeksandrov ealeksandrov commented Nov 9, 2022 •
edited
Loading

Part of #8066

Description

This PR adds a new analytics event for the "Preview" button tap on the product details:

  • *_product_detail_preview_tapped (Event registration: 1172-gh-tracks-events-registration)

Mobile Tracks spreadsheet updated.

Testing

  1. Build and run the app in debug/alpha mode.
  2. Open details for a draft product.
  3. Tap the "Preview" button in the navbar. Confirm the event is triggered.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ealeksandrov ealeksandrov added feature: product details Related to adding or editing products, including Product Settings. category: tracks Related to analytics, including Tracks Events. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels Nov 9, 2022
@ealeksandrov ealeksandrov added this to the 11.2 milestone Nov 9, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 9, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8070-c4d74f3 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ealeksandrov ealeksandrov marked this pull request as ready for review November 9, 2022 16:07
@ealeksandrov ealeksandrov changed the title Add product_detail_preview_tapped event Products Onboarding: Add product_detail_preview_tapped event Nov 9, 2022
@ealeksandrov
Merge branch 'trunk' into issue/8066-product-preview-analytics
c4d74f3 
# Conflicts:
#	WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift
@ealeksandrov ealeksandrov merged commit c077d1c into trunk Nov 10, 2022
@ealeksandrov ealeksandrov deleted the issue/8066-product-preview-analytics branch November 10, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachelmcr rachelmcr Awaiting requested review from rachelmcr

1 more reviewer

@Ecarrion Ecarrion Ecarrion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: tracks Related to analytics, including Tracks Events. feature: product details Related to adding or editing products, including Product Settings. status: feature-flagged Behind a feature flag. Milestone is not strongly held.

Projects

None yet

Milestone

11.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ealeksandrov @wpmobilebot @Ecarrion