Skip to content

Products Onboarding: Add product_detail_preview_tapped event #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Products Onboarding: Add product_detail_preview_tapped event #8070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb99233
Add product_detail_preview_tapped event
ealeksandrov Nov 9, 2022
c4d74f3
Merge branch 'trunk' into issue/8066-product-preview-analytics
ealeksandrov Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions WooCommerce/Classes/Analytics/WooAnalyticsEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,12 @@ extension WooAnalyticsEvent {
static func loaded(hasLinkedProducts: Bool) -> WooAnalyticsEvent {
WooAnalyticsEvent(statName: .productDetailLoaded, properties: ["has_linked_products": hasLinkedProducts])
}

/// Tracks when the merchant previews a product draft.
///
static func previewTapped() -> WooAnalyticsEvent {
WooAnalyticsEvent(statName: .productDetailPreviewTapped, properties: [:])
}
}
}

Expand Down
1 change: 1 addition & 0 deletions WooCommerce/Classes/Analytics/WooAnalyticsStat.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@ public enum WooAnalyticsStat: String {
case productDetailViewProductAddOnsTapped = "product_detail_view_product_addons_tapped"
case productInventorySettingsSKUScannerButtonTapped = "product_inventory_settings_sku_scanner_button_tapped"
case productInventorySettingsSKUScanned = "product_inventory_settings_sku_scanned"
case productDetailPreviewTapped = "product_detail_preview_tapped"

// MARK: Edit Product Variation Events
//
Expand Down
2 changes: 2 additions & 0 deletions WooCommerce/Classes/ViewRelated/Products/Edit Product/ProductFormViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ final class ProductFormViewController<ViewModel: ProductFormViewModelProtocol>:
}

private func displayProductPreview() {
ServiceLocator.analytics.track(event: .ProductDetail.previewTapped())

guard var permalink = URLComponents(string: product.permalink),
let nonce = ServiceLocator.stores.sessionManager.defaultSite?.frameNonce else {
return
Expand Down