-
Notifications
You must be signed in to change notification settings - Fork 121
kUTType was deprecated in iOS15, use UTType instead #8093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d47d918
Change kUUTypeJPEG for UTTtype
iamgabrielma 6aca4a5
Change kUUTypeGIF for UTTtype.gif.identifier
iamgabrielma 421471e
Change kUUType for UTType in URL+MediaTests
iamgabrielma 2521b0e
Update UTType MediaImageExporterTests
iamgabrielma 6530b16
Remove redundant typecast
iamgabrielma 71b42df
Remove UTTypeEqual usage
iamgabrielma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -50,7 +50,8 @@ final class MediaAssetExporter: MediaExporter { | |||||||
| if let resource = resources.first { | ||||||||
| resourceAvailableLocally = true | ||||||||
| filename = resource.originalFilename | ||||||||
| if UTTypeEqual(resource.uniformTypeIdentifier as CFString, kUTTypeGIF) { | ||||||||
| let gifTypeIdentifier = UTType.gif.identifier as CFString | ||||||||
| if UTTypeEqual(resource.uniformTypeIdentifier as CFString, gifTypeIdentifier) { | ||||||||
| // Handles GIF export differently from images. | ||||||||
| exportGIF(forAsset: asset, resource: resource, onCompletion: onCompletion) | ||||||||
| return | ||||||||
|
|
@@ -112,7 +113,7 @@ private extension MediaAssetExporter { | |||||||
| return nil | ||||||||
| } | ||||||||
| guard allowableFileExtensions.contains(fileExtensionForType) else { | ||||||||
| return kUTTypeJPEG as String | ||||||||
| return UTType.jpeg.identifier as String | ||||||||
iamgabrielma marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||
| } | ||||||||
| return uti | ||||||||
| } | ||||||||
|
|
@@ -123,7 +124,8 @@ private extension MediaAssetExporter { | |||||||
| /// - parameter onError: Called if an error was encountered during export. | ||||||||
| /// | ||||||||
| private func exportGIF(forAsset asset: PHAsset, resource: PHAssetResource, onCompletion: @escaping MediaExportCompletion) { | ||||||||
| guard UTTypeEqual(resource.uniformTypeIdentifier as CFString, kUTTypeGIF) else { | ||||||||
| let gifTypeIdentifier = UTType.gif.identifier as CFString | ||||||||
| guard UTTypeEqual(resource.uniformTypeIdentifier as CFString, gifTypeIdentifier) else { | ||||||||
|
||||||||
| let gifTypeIdentifier = UTType.gif.identifier as CFString | |
| guard UTTypeEqual(resource.uniformTypeIdentifier as CFString, gifTypeIdentifier) else { | |
| guard resource.uniformTypeIdentifier == UTType.gif.identifier else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think comparing the identifier strings directly should be fine?