Skip to content

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Nov 14, 2022

Part of #8106

Description

After domain selection and before IAP, we need to create a free site and then pass the site ID for purchasing the eCommerce plan via IAP. This PR includes the Networking & Yosemite layer changes for creating a site, with parameters following the woocommerce.com/start flow on the web (the store configurations might change after the store becomes Atomic after IAP success). Sorry about the changes exceeding 500 diffs slightly 🙇🏻‍♀️ I thought it's easier to review both the remote and Yosemite store, especially for error handling and why we need to manually convert the site ID string from the Networking layer response to Int64 in Yosemite.

SiteAction was previously used in Yosemite unit tests, and I renamed it to MockSiteAction to avoid naming conflict.

Testing instructions

The new SiteAction.createSite isn't used in the app, just CI is sufficient. Integration with the store creation flow will be in a separate PR.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jaclync jaclync added the type: task An internally driven task. label Nov 14, 2022
@jaclync jaclync added this to the 11.3 milestone Nov 14, 2022
@peril-woocommerce
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8107-6a6a686 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jaclync jaclync merged commit 43203f6 into trunk Nov 15, 2022
@jaclync jaclync deleted the feat/site-creation-foundation branch November 15, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants