Skip to content

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Dec 2, 2022

Closes: #

Description

Before the Moooore IPP project, we added a feature announcement banner in settings on top of where we had the Payments row. After that, we hid the banner from our users, but we left some remnants of that in our code. With this PR we remove these.

Testing instructions

Unit tests should pass.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@toupper toupper added the type: task An internally driven task. label Dec 2, 2022
@toupper toupper added this to the 11.6 milestone Dec 2, 2022
@toupper toupper requested a review from joshheald December 2, 2022 17:09
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8302-e222dc6 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, menu all still works fine and tests pass. Thanks for doing the cleanup! 🚢

@toupper toupper merged commit c9ee001 into trunk Dec 5, 2022
@toupper toupper deleted the task/remove-upsell-card-readers-settings-leftovers branch December 5, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants