[Analytics Hub] Update colors for delta tag and chart with 0% change #8317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8243
Description
This updates the Analytics Hub to use a gray color (instead of red) for stats with a 0% change from the previous period:
Changes
DeltaPercentage.Direction, since they are inherently linked to the delta direction.Note: The original idea behind
DeltaPercentagewas to just be a representation of the formatted string/direction inStatsDataTextFormatter. Given that so many report card values depend on theDeltaPercentage, I think it makes sense to extract that struct from the formatter as its own entity. Then, we can pass theDeltaPercentageitself to the analytics card view models (rather than passing each of the values separately). I'll open a separate PR so we can review that idea.Testing
Screenshots
Submitter Checklist
Update release notes:
RELEASE-NOTES.txtif necessary.