-
Notifications
You must be signed in to change notification settings - Fork 121
[Analytics Hub] Add new standard tracks events #8335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Analytics Hub] Add new standard tracks events #8335
Conversation
You can test the changes from this Pull Request by:
|
ealeksandrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ![]()
|
Related: an all event registration PRs I see |
Thanks for catching that! I fixed that for all events in 1239-gh-tracks-events-registration, and they're now showing as registered. |
Generated by 🚫 dangerJS |
Part of: #8323
Description
Adds new analytics events for the Analytics Hub:
_dashboard_see_more_analytics_tapped(Event registration: 1231-gh-tracks-events-registration)_analytics_hub_date_range_button_tapped(Event registration: 1232-gh-tracks-events-registration)_analytics_hub_date_range_option_selectedwithoptionevent prop (Event registration: 1233-gh-tracks-events-registration)Note: Updates to the existing
used_analyticsevent will be done in another PR.Testing
_dashboard_see_more_analytics_tappedevent is triggered._analytics_hub_date_range_button_tappedevent is triggered._analytics_hub_date_range_option_selectedevent is triggered and includes anoptionproperty with the selected date range (untranslated, matching theoptionvalues used in the Android analytics event).Submitter Checklist
Update release notes:
RELEASE-NOTES.txtif necessary.