Skip to content

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Dec 7, 2022

Part of: #8323

Description

Adds new analytics events for the Analytics Hub:

  • _dashboard_see_more_analytics_tapped (Event registration: 1231-gh-tracks-events-registration)
  • _analytics_hub_date_range_button_tapped (Event registration: 1232-gh-tracks-events-registration)
  • _analytics_hub_date_range_option_selected with option event prop (Event registration: 1233-gh-tracks-events-registration)

Note: Updates to the existing used_analytics event will be done in another PR.

Testing

  1. Launch the app.
  2. Tap "See more" on the My Store dashboard and confirm the _dashboard_see_more_analytics_tapped event is triggered.
  3. On the Analytics screen, tap the date range selector and confirm the _analytics_hub_date_range_button_tapped event is triggered.
  4. In the date range selector, tap on a new date range and confirm the _analytics_hub_date_range_option_selected event is triggered and includes an option property with the selected date range (untranslated, matching the option values used in the Android analytics event).

Submitter Checklist

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added the category: tracks Related to analytics, including Tracks Events. label Dec 7, 2022
@rachelmcr rachelmcr added this to the 11.6 milestone Dec 7, 2022
@rachelmcr rachelmcr marked this pull request as ready for review December 7, 2022 17:33
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 7, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8335-54bb55c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr rachelmcr linked an issue Dec 7, 2022 that may be closed by this pull request
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ealeksandrov
Copy link
Contributor

Related: an all event registration PRs I see is_registered: false, is that expected? I don't know what it impacts, but previously this value was true for similar registrations. Also we have many false examples for existing mobile events, although most of them are older.

@rachelmcr
Copy link
Contributor Author

Related: an all event registration PRs I see is_registered: false, is that expected?

Thanks for catching that! I fixed that for all events in 1239-gh-tracks-events-registration, and they're now showing as registered.

@peril-woocommerce
Copy link

Messages
📖

This PR contains changes to Tracks-related logic. Please ensure the following are completed:
PR Author

  • The PR must be assigned the Tracks label
    PR Reviewer
  • The tracks events must be validated in the Tracks system.
  • Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

@rachelmcr rachelmcr enabled auto-merge December 8, 2022 11:20
@rachelmcr rachelmcr merged commit 8f948db into trunk Dec 8, 2022
@rachelmcr rachelmcr deleted the issue/8323-analytics-hub-standard-tracks-events branch December 8, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Add Tracks events

4 participants