Skip to content

Conversation

@ealeksandrov
Copy link
Contributor

Closes: #8367

Description

This PR adds a logic to hide the "Sessions" card for "custom" time range.

Testing

  1. Build and run the app in debug/alpha mode.
  2. On the dashboard view tap the "See more" button.
  3. Scroll to the "Sessions" card in bottom of a list, verify it's displayed.
  4. On top of the list tap range selector and pick "Custom" with any start-end dates.
  5. Scroll to the bottom of a list, verify the "Sessions" card is hidden.
  6. Pick any non-custom range, verify "Sessions" card is displayed again.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ealeksandrov ealeksandrov added the feature: stats Related to stats, including Top Performers. label Dec 15, 2022
@ealeksandrov ealeksandrov added this to the 11.7 milestone Dec 15, 2022
@peril-woocommerce
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@ealeksandrov ealeksandrov changed the title [Analytics Hub] Hide session card conditionally [Analytics Hub] Hide Sessions card conditionally Dec 15, 2022
@Ecarrion Ecarrion self-assigned this Dec 15, 2022
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8422-20569e9 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@Ecarrion Ecarrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@ealeksandrov ealeksandrov merged commit 3c3e38c into trunk Dec 16, 2022
@ealeksandrov ealeksandrov deleted the issue/8367-hide-session-card branch December 16, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: stats Related to stats, including Top Performers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Hide Sessions analytics card when a custom date range is selected

4 participants