Skip to content

[Analytics Hub] Hide Sessions card conditionally #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022
Merged

[Analytics Hub] Hide Sessions card conditionally #8422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7c7032
Display sessions card conditionally
ealeksandrov Dec 15, 2022
20569e9
Add test
ealeksandrov Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ struct AnalyticsHubView: View {

Divider()
}
.renderedIf(ServiceLocator.featureFlagService.isFeatureFlagEnabled(.analyticsHub))
.renderedIf(ServiceLocator.featureFlagService.isFeatureFlagEnabled(.analyticsHub) && viewModel.showSessionsCard)

Spacer()
}
Expand Down
11 changes: 11 additions & 0 deletions WooCommerce/Classes/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,17 @@ final class AnalyticsHubViewModel: ObservableObject {
///
@Published var sessionsCard = AnalyticsHubViewModel.sessionsCard(currentPeriodStats: nil, siteStats: nil)

/// Sessions Card display state
///
var showSessionsCard: Bool {
switch timeRangeSelectionType {
case .custom:
return false
default:
return true
}
}

/// Time Range Selection Type
///
@Published var timeRangeSelectionType: AnalyticsHubTimeRangeSelection.SelectionType
Expand Down
18 changes: 18 additions & 0 deletions ...rce/WooCommerceTests/ViewRelated/Dashboard/Analytics Hub/AnalyticsHubViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,22 @@ final class AnalyticsHubViewModelTests: XCTestCase {
XCTAssertEqual(loadingItemsSoldCard?.isRedacted, true)
XCTAssertEqual(loadingSessionsCard?.isRedacted, true)
}

func test_session_card_is_hidden_for_custom_range() async {
// Given
let vm = AnalyticsHubViewModel(siteID: 123, statsTimeRange: .today, usageTracksEventEmitter: eventEmitter, stores: stores)
XCTAssertTrue(vm.showSessionsCard)

// When
vm.timeRangeSelectionType = .custom(start: Date(), end: Date())

// Then
XCTAssertFalse(vm.showSessionsCard)

// When
vm.timeRangeSelectionType = .lastMonth

// Then
XCTAssertTrue(vm.showSessionsCard)
}
}