Skip to content

[Analytics Hub] Release Sessions card and remove feature flag #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2022
Merged

[Analytics Hub] Release Sessions card and remove feature flag #8428

merged 4 commits into from
Dec 16, 2022
+2 −7

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Dec 15, 2022 •
edited
Loading

Closes: #8324

Description

This PR removes the Analytics Hub feature flag and releases the Analytics Sessions card (Views and Conversion Rate stats).

Should be merged after #8422 (required) and #8427 (better for consistency, but not required).

Testing instructions

  1. Build and run the app.
  2. Tap "See more" to open Analytics.
  3. Confirm the Sessions card appears as expected.

Screenshots

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added the feature: stats Related to stats, including Top Performers. label Dec 15, 2022
@rachelmcr rachelmcr added this to the 11.7 milestone Dec 15, 2022
@rachelmcr rachelmcr marked this pull request as ready for review December 15, 2022 18:22
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 15, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8428-411a4f8 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@peril-woocommerce
Copy link

peril-woocommerce bot commented Dec 16, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

ealeksandrov
ealeksandrov approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rachelmcr rachelmcr enabled auto-merge December 16, 2022 12:10
@rachelmcr rachelmcr merged commit 7504066 into trunk Dec 16, 2022
@rachelmcr rachelmcr deleted the issue/8324-release-sessions-card branch December 16, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

@Ecarrion Ecarrion Awaiting requested review from Ecarrion

1 more reviewer

@ealeksandrov ealeksandrov ealeksandrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: stats Related to stats, including Top Performers.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Create and configure Sessions Analytics card (Master Issue)

4 participants

@rachelmcr @wpmobilebot @ealeksandrov