Skip to content

Conclude native Jetpack install experiment #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 4, 2023
Merged

Conclude native Jetpack install experiment #8533

merged 6 commits into from
Jan 4, 2023

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Jan 3, 2023 •
edited
Loading

Part of: #8514

Description

This PR removes the A/B testing experiment code and enables the native Jetpack installation process for all users.

Changes

  • Remove A/B test case nativeJetpackSetupFlow
  • Enable native Jetpack setup flow for all users.

Testing instructions

  • Log out of the app or skip login onboarding if needed.
  • On the prologue screen, select "Log In" or "Continue with WordPress.com" based on the A/B test variant you get.
  • Log in with your WordPress.com account.
  • If your account doesn't have any associated site, notice that the empty store picker is displayed with the matching design as on Figma.
  • Select Add a Store > Connect an existing site.
  • Enter the address of your test store and tap Continue.
  • You should see a Jetpack error screen from where you can Install Jetpack or Connect Jetpack natively.

Screenshots

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 3, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8533-07fd62c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@selanthiraiyan selanthiraiyan added type: task An internally driven task. feature: login Related to any part of the log in or sign in flow, or authentication. labels Jan 3, 2023
@selanthiraiyan selanthiraiyan added this to the 11.8 milestone Jan 3, 2023
@selanthiraiyan selanthiraiyan marked this pull request as ready for review January 3, 2023 12:43
@selanthiraiyan selanthiraiyan mentioned this pull request Jan 3, 2023
Closed
3 tasks
@jaclync jaclync self-assigned this Jan 4, 2023
jaclync
jaclync approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 even though Jetpack installation failed for a JCP JN site that isn't connected to the WPCOM user, the flow worked.

WooCommerce/Classes/Authentication/AuthenticationManager.swift Outdated
let isSimplifiedLoginI1Enabled = ABTest.abTestLoginWithWPComOnly.variation != .control
let isStoreCreationMVPEnabled = featureFlagService.isFeatureFlagEnabled(.storeCreationMVP)
let isNativeJetpackSetupEnabled = ABTest.nativeJetpackSetupFlow.variation != .control
let isNativeJetpackSetupEnabled = true
Copy link
Contributor

@jaclync jaclync Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: how about just passing true to where this variable is used since it's a constant now?

Copy link
Contributor Author

@selanthiraiyan selanthiraiyan Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 82093c1

@selanthiraiyan selanthiraiyan force-pushed the feat/8514-conclude-native-jetpack-install branch from 82093c1 to 07fd62c Compare January 4, 2023 05:17
@selanthiraiyan
Copy link
Contributor Author

selanthiraiyan commented Jan 4, 2023

Jetpack installation failed for a JCP JN site that isn't connected to the WPCOM user

Thanks for raising the issue about JCP sites, @jaclync

@itsmeichigo and I looked into it and decided to create an issue here. #8542

@selanthiraiyan selanthiraiyan merged commit 8ff603e into trunk Jan 4, 2023
@selanthiraiyan selanthiraiyan deleted the feat/8514-conclude-native-jetpack-install branch January 4, 2023 07:11
@selanthiraiyan selanthiraiyan mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

@itsmeichigo itsmeichigo Awaiting requested review from itsmeichigo

Assignees

@jaclync jaclync

Labels

feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

4 participants

@selanthiraiyan @wpmobilebot @jaclync