-
Notifications
You must be signed in to change notification settings - Fork 121
Bulk Editing: Add selection state to products list #8563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can test the changes from this Pull Request by:
|
| } | ||
|
|
||
| func configureNavigationBarTitleForEditing() { | ||
| let selectedProducts = tableView.indexPathsForSelectedRows?.count ?? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we can use tableView.indexPathsForSelectedRows safely. When the table view reloads due to a page being loaded this property gets cleaned.
issue-with-selection.mov
I think we will have to change how we update the table view with new pages or we will have to store these selections on a view model.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Added ProductsListViewModel to store selection state.
Ecarrion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WooCommerce/Classes/ViewRelated/Products/ProductsListViewModel.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Ernesto Carrión <[email protected]>
|
Thanks! Created #8608 |

Part of: #8517
Description
This PR adds bulk editing state on Products List.
It replaces navbar content, disables pull-to-refresh, switches table view into multiple selection mode.
Testing
Video
Simulator.Screen.Recording.mp4
RELEASE-NOTES.txtif necessary.