-
Notifications
You must be signed in to change notification settings - Fork 121
Bulk Editing: Add selection state to products list #8563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
628eb69
Add multiple selection on products
ealeksandrov 8c34db7
Disable pull-to-refresh while editing
ealeksandrov 8cad497
Hide filters toolbar while editing
ealeksandrov dd2c0c7
Add cancel button
ealeksandrov 4aaa575
Update navbar title
ealeksandrov 84322b5
Update navbar title on selection change
ealeksandrov 0957edc
Move localized strings to enum
ealeksandrov 037ed02
Merge branch 'trunk' into issue/8517-selection-state
ealeksandrov e90c6ed
Add ProductsListViewModel
ealeksandrov 13df218
Use ProductsListViewModel to store selection state
ealeksandrov 09db3ad
Cleanup commented out code
ealeksandrov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we can use
tableView.indexPathsForSelectedRowssafely. When the table view reloads due to a page being loaded this property gets cleaned.issue-with-selection.mov
I think we will have to change how we update the table view with new pages or we will have to store these selections on a view model.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Added
ProductsListViewModelto store selection state.