Skip to content

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Jan 18, 2023

Related to: wordpress-mobile/WordPressAuthenticator-iOS#724

Description

To avoid changing the tracks event for WordPress Mobile application, we have introduced a configuration flag in wordpress-mobile/WordPressAuthenticator-iOS#724

This PR uses the new configuration flag to get a custom step value for the tracks event from GetStartedViewController

Testing instructions

  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select "Continue with WordPress.com" land in the GetStartedViewController (Ref screenshot below)
  • Check the Xcode console and ensure that the following event is tracked
Tracked unified_login_step, properties: [AnyHashable("source"): "default", AnyHashable("step"): "enter_email_address", AnyHashable("flow"): "wordpress_com"]
  • Notice that the step value is enter_email_address as we have enabled the useEnterEmailAddressAsStepValueForGetStartedVC flag in WordPressAuthenticatorConfiguration

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@selanthiraiyan selanthiraiyan added the feature: login Related to any part of the log in or sign in flow, or authentication. label Jan 18, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 18, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8669-bc7b5c4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@selanthiraiyan selanthiraiyan merged commit 7aec9d4 into trunk Jan 18, 2023
@selanthiraiyan selanthiraiyan deleted the bugfix/wpauthenticator-723-config-flag-for-custom-step-value branch January 18, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: login Related to any part of the log in or sign in flow, or authentication.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants