Skip to content

WPAuthenticator - Config flag to enable custom step value for get started screen. #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2023
Merged

WPAuthenticator - Config flag to enable custom step value for get started screen. #8669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e45cdfd
Point `WordPressAuthenticator` to beta commit version.
selanthiraiyan Jan 18, 2023
c278123
Enable custom step value flag in authenticator config.
selanthiraiyan Jan 18, 2023
87642d3
Point WordPressAuthenticator pod to beta release version.
selanthiraiyan Jan 18, 2023
bc7b5c4
Update pod file checksum.
selanthiraiyan Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ target 'WooCommerce' do
pod 'Gridicons', '~> 1.2.0'

# To allow pod to pick up beta versions use -beta. E.g., 1.1.7-beta.1
pod 'WordPressAuthenticator', '~> 5.0.0'
pod 'WordPressAuthenticator', '~> 5.1.0-beta.1'
# pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :commit => ''
# pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :branch => ''
# pod 'WordPressAuthenticator', :path => '../WordPressAuthenticator-iOS'
Expand Down
8 changes: 4 additions & 4 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ PODS:
- WordPress-Aztec-iOS (1.11.0)
- WordPress-Editor-iOS (1.11.0):
- WordPress-Aztec-iOS (= 1.11.0)
- WordPressAuthenticator (5.0.0):
- WordPressAuthenticator (5.1.0-beta.1):
- GoogleSignIn (~> 6.0.1)
- Gridicons (~> 1.0)
- "NSURL+IDN (= 0.4)"
Expand Down Expand Up @@ -84,7 +84,7 @@ DEPENDENCIES:
- Sourcery (~> 1.0.3)
- StripeTerminal (~> 2.14)
- WordPress-Editor-iOS (~> 1.11.0)
- WordPressAuthenticator (~> 5.0.0)
- WordPressAuthenticator (~> 5.1.0-beta.1)
- WordPressKit (~> 5.0.0)
- WordPressShared (~> 2.0)
- WordPressUI (~> 1.12.5)
Expand Down Expand Up @@ -153,7 +153,7 @@ SPEC CHECKSUMS:
UIDeviceIdentifier: f33af270ba9045ea18b31d9aab88e42a0082ea67
WordPress-Aztec-iOS: 050b34d4c3adfb7c60363849049b13d60683b348
WordPress-Editor-iOS: 304098424f1051cb271546c99f906aac296b1b81
WordPressAuthenticator: 0cdf1bff75bd3f58fe733d6457221f27bbbdc9f4
WordPressAuthenticator: b4df3148e7a7c1ad739bcbe6cc7b5ce728a1b15d
WordPressKit: 202f529323b079a344f7bc1493b7ebebfd9ed4b5
WordPressShared: 35d41bdf0927e714af1fc85fa9cb692f934473be
WordPressUI: c5be816f6c7b3392224ac21de9e521e89fa108ac
Expand All @@ -169,6 +169,6 @@ SPEC CHECKSUMS:
ZendeskSupportProvidersSDK: 2bdf8544f7cd0fd4c002546f5704b813845beb2a
ZendeskSupportSDK: 3a8e508ab1d9dd22dc038df6c694466414e037ba

PODFILE CHECKSUM: 17ff88b703dd664331487078325e3a051db87976
PODFILE CHECKSUM: d9ae1586866c135c8c538e08c02a66f17b63c344

COCOAPODS: 1.11.3
3 changes: 2 additions & 1 deletion WooCommerce/Classes/Authentication/AuthenticationManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ class AuthenticationManager: Authentication {
emphasizeEmailForWPComPassword: true,
wpcomPasswordInstructions:
AuthenticationConstants.wpcomPasswordInstructions,
skipXMLRPCCheckForSiteDiscovery: true)
skipXMLRPCCheckForSiteDiscovery: true,
useEnterEmailAddressAsStepValueForGetStartedVC: true)

let systemGray3LightModeColor = UIColor(red: 199/255.0, green: 199/255.0, blue: 204/255.0, alpha: 1)
let systemLabelLightModeColor = UIColor(red: 0, green: 0, blue: 0, alpha: 1)
Expand Down