Dashboard: Add button to share store #9796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
You can test the changes from this Pull Request by:
|
9 tasks
selanthiraiyan
approved these changes
May 23, 2023
Contributor
selanthiraiyan
left a comment
selanthiraiyan
left a comment
There was a problem hiding this comment.
This works as expected. 🎉 🚢
|
|
||
| func configureShareButton() { | ||
| // Only show share button if the site is public. | ||
| guard let site = ServiceLocator.stores.sessionManager.defaultSite, site.isPublic else { |
Contributor
There was a problem hiding this comment.
Nit: Moving this to view model will allow us to unit test this.
| } | ||
|
|
||
| @objc | ||
| func shareStore() { |
Contributor
There was a problem hiding this comment.
Nit: This logic could be moved to view model as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9785
Description
This PR adds a button to the top right of the My Store screen to let merchants share their stores.
Testing instructions
🔵 Tracked dashboard_share_your_store_button_tapped.Screenshots
RELEASE-NOTES.txtif necessary.