-
Notifications
You must be signed in to change notification settings - Fork 121
Dashboard: Add button to share store #9796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8428670
Add button to share store from the My Store screen
itsmeichigo 044212f
Track share button tapped
itsmeichigo cf7a6cf
Update release notes
itsmeichigo 7e8c764
Only show the share button if the site is public
itsmeichigo 1ec15ac
Move share URL logic to dashboard view model
itsmeichigo b9ddde8
Update unit test for dashboard view model
itsmeichigo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,6 +79,8 @@ final class DashboardViewController: UIViewController { | |
| return view | ||
| }() | ||
|
|
||
| private lazy var shareButton = UIBarButtonItem(barButtonSystemItem: .action, target: self, action: #selector(shareStore)) | ||
|
|
||
| /// Stores an animator for showing/hiding the header view while there is an animation in progress | ||
| /// so we can interrupt and reverse if needed | ||
| private var headerAnimator: UIViewPropertyAnimator? | ||
|
|
@@ -303,6 +305,7 @@ private extension DashboardViewController { | |
| configureTitle() | ||
| configureContainerStackView() | ||
| configureHeaderStackView() | ||
| configureShareButton() | ||
| } | ||
|
|
||
| func configureTabBarItem() { | ||
|
|
@@ -315,6 +318,24 @@ private extension DashboardViewController { | |
| navigationItem.title = Localization.title | ||
| } | ||
|
|
||
| func configureShareButton() { | ||
| // Only show share button if the site is public. | ||
| guard let site = ServiceLocator.stores.sessionManager.defaultSite, site.isPublic else { | ||
| return | ||
| } | ||
| navigationItem.rightBarButtonItem = shareButton | ||
| } | ||
|
|
||
| @objc | ||
| func shareStore() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: This logic could be moved to view model as well.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also updated in 1ec15ac. |
||
| guard let site = ServiceLocator.stores.sessionManager.defaultSite, | ||
| let url = URL(string: site.url) else { | ||
| return | ||
| } | ||
| SharingHelper.shareURL(url: url, from: shareButton, in: self) | ||
| ServiceLocator.analytics.track(.dashboardShareStoreButtonTapped) | ||
| } | ||
|
|
||
| func configureContainerStackView() { | ||
| containerStackView.axis = .vertical | ||
| containerView.addSubview(containerStackView) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Moving this to view model will allow us to unit test this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this in 1ec15ac 👍