Skip to content

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented May 25, 2023

Description

We have a Learn More link in each of the card reader related screens from the Payment menu:

  • Set up Tap to Pay on iPhone
  • Manage Card Reader

These screens are functionally equivalent – when there's no reader connected, they show and the user can learn more about getting started with IPP/TTP

Taps on these screens were not tracked, unlike other learn more links across the system.

From both screens, we now log the existing in_person_payments_learn_more_tapped event.

From the Set up Tap to Pay on iPhone screen, we use the source: tap_to_pay_summary – this is agreed to match and be suitable for both iOS and Android pdfdoF-2WK-p2

From the Manage Card Reader screen, we use the source: manage_card_reader.

Testing instructions

Launch the app
Navigate to Menu > Payments > Set up Tap to Pay on iPhone
Tap Learn More
Observe that the in_person_payments_learn_more_tapped event is logged with the source: tap_to_pay_summary
Tap back
Tap Manage card reader
Tap Learn More
Observe that the in_person_payments_learn_more_tapped event is logged with the source: manage_card_reader

Screenshots

Console log showing the in_person_payments_learn_more_tapped event with source tap_to_pay_summary Console log showing the in_person_payments_learn_more_tapped event with source manage_card_reader
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald joshheald added type: task An internally driven task. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels May 25, 2023
@joshheald joshheald modified the milestones: 13.9, 13.8 May 25, 2023
@joshheald joshheald marked this pull request as ready for review May 25, 2023 12:16
@joshheald joshheald enabled auto-merge May 25, 2023 12:16
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9820-0788623 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@joshheald joshheald requested a review from toupper May 25, 2023 12:35
@toupper toupper self-assigned this May 25, 2023
Copy link
Contributor

@toupper toupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job,it looks good and tests well :shipit: 🚢 As a reminder, we can update the Mobile Events spreadsheet with this new property, and register the event in Tracks.

@joshheald joshheald merged commit 1c2e6b0 into trunk May 25, 2023
@joshheald joshheald deleted the issue/track-learn-more-tapped-everywher branch May 25, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants