Skip to content

[Mobile Payments] Track when Learn More is tapped on Set up Tap to Pay and Manage Card Reader screens #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2023
Merged

[Mobile Payments] Track when Learn More is tapped on Set up Tap to Pay and Manage Card Reader screens #9820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47adf65
Track learnMoreTapped event with tap to pay source
joshheald May 25, 2023
0ee9d6f
Track learnMoreTapped on Manage Card Reader
joshheald May 25, 2023
0788623
Use correct learn more event for manageCardReader
joshheald May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions WooCommerce/Classes/Analytics/WooAnalyticsEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1893,13 +1893,19 @@ extension WooAnalyticsEvent {
enum LearnMoreLinkSource {
case paymentsMenu
case paymentMethods
case tapToPaySummary
case manageCardReader

var trackingValue: String {
switch self {
case .paymentsMenu:
return "payments_menu"
case .paymentMethods:
return "payment_methods"
case .tapToPaySummary:
return "tap_to_pay_summary"
case .manageCardReader:
return "manage_card_reader"
}
}
}
Expand Down
37 changes: 19 additions & 18 deletions ...wRelated/Dashboard/Settings/CardReadersV2/CardReaderSettingsSearchingViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,28 +147,29 @@ struct CardReaderSettingsSearchingView: View {
.buttonStyle(PrimaryButtonStyle())
.padding(.bottom, 8)

InPersonPaymentsLearnMore()
.customOpenURL(action: { url in
switch url {
case LearnMoreViewModel.learnMoreURL:
if let url = learnMoreUrl {
showURL?(url)
}
default:
InPersonPaymentsLearnMore(viewModel: LearnMoreViewModel(
tappedAnalyticEvent: WooAnalyticsEvent.InPersonPayments.learnMoreTapped(source: .manageCardReader)))
.customOpenURL(action: { url in
switch url {
case LearnMoreViewModel.learnMoreURL:
if let url = learnMoreUrl {
showURL?(url)
}
})
}
.frame(
maxWidth: .infinity,
maxHeight: .infinity
)
.padding()
.if(isCompact || isSizeCategoryLargeThanExtraLarge) {content in
ScrollView(.vertical) {
content
default:
showURL?(url)
}
})
}
.frame(
maxWidth: .infinity,
maxHeight: .infinity
)
.padding()
.if(isCompact || isSizeCategoryLargeThanExtraLarge) {content in
ScrollView(.vertical) {
content
}
}
}
}

Expand Down
4 changes: 3 additions & 1 deletion ...ViewRelated/Dashboard/Settings/CardReadersV2/SetUpTapToPayInformationViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ struct SetUpTapToPayInformationView: View {
.disabled(!viewModel.enableSetup)

InPersonPaymentsLearnMore(
viewModel: LearnMoreViewModel(formatText: Localization.learnMore))
viewModel: LearnMoreViewModel(
formatText: Localization.learnMore,
tappedAnalyticEvent: WooAnalyticsEvent.InPersonPayments.learnMoreTapped(source: .tapToPaySummary)))
.customOpenURL(action: { url in
switch url {
case LearnMoreViewModel.learnMoreURL:
Expand Down