Skip to content

Conversation

@wargcm
Copy link
Contributor

@wargcm wargcm commented Dec 8, 2022

Fixes #19609

Description

Fixes a crash on the dashboard when VoiceOver is enabled.

One class inherits from DynamicHeightCollectionView and the dashboard uses it. The accessibility code has been added to TopicsCollectionView so it continues to work properly with VoiceOver.

Testing

To test:

Testing the launch crash

  • Use a real device and login
  • Set/verify initial screen is set to Home (MeApp SettingsInitial Screen)
  • Close the app
  • Enable VoiceOver
  • Launch the app
  • Verify it does not crash

Reader topics

  • Use a real device and enable VoiceOver
  • Login
  • Navigate to the Reader tab
  • Tap on Discover
  • Select topics if necessary and hit 'Done'
  • Find a post with many tags (Should have an N+ tag like 4+)
  • Expand the tags
  • Swipe left and verify it voices each tag

Regression Notes

  1. Potential unintended areas of impact
    Reader topic VoiceOver

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wargcm wargcm added this to the 21.4 milestone Dec 8, 2022
@wargcm wargcm requested review from alpavanoglu and dvdchr December 8, 2022 02:10
@wargcm wargcm self-assigned this Dec 8, 2022
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19751-c5aa0da on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19751-c5aa0da on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@dvdchr
Copy link
Contributor

dvdchr commented Dec 9, 2022

Reviewing!

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • ✅ Verified launching the app with the Home dashboard set with initial screen doesn't crash.
  • ✅ Verified expanding N+ topics and swiping left properly dictates the topics and doesn't crash.

@wargcm wargcm merged commit 99166f7 into trunk Dec 9, 2022
@wargcm wargcm deleted the bug/19609-fix-voice-over-crash branch December 9, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Crash VoiceOver Better VoiceOver support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crashes when opened with VoiceOver if the initial page is Home

4 participants