Skip to content

Fix VoiceOver crash when initial screen is Home #19751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix VoiceOver crash when initial screen is Home #19751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPress/Classes/ViewRelated/Reader/Tags View/DynamicHeightCollectionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Foundation

class DynamicHeightCollectionView: AccessibleCollectionView {
class DynamicHeightCollectionView: UICollectionView {
override func layoutSubviews() {
super.layoutSubviews()

Expand Down
8 changes: 8 additions & 0 deletions WordPress/Classes/ViewRelated/Reader/Tags View/TopicsCollectionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ class TopicsCollectionView: DynamicHeightCollectionView {
func collapse() {
coordinator?.changeState(.collapsed)
}

override func accessibilityElementCount() -> Int {
guard let dataSource else {
return 0
}

return dataSource.collectionView(self, numberOfItemsInSection: 0)
}
}

extension TopicsCollectionView: ReaderTopicCollectionViewCoordinatorDelegate {
Expand Down