Skip to content

Fix crash when perform is called on a context with deprecated concurrency type #19765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Fix crash when perform is called on a context with deprecated concurrency type #19765

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b35a71
Do not run perform if context concurrency is confined
dvdchr Dec 9, 2022
8ff226c
Merge remote-tracking branch 'origin/trunk' into fix/skip-perform-on-…
dvdchr Dec 12, 2022
0caa881
Add tests for ContainerContextFactory
dvdchr Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions WordPress/Classes/Utility/ContainerContextFactory.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ class ContainerContextFactory: NSObject, ManagedObjectContextFactory {
completionBlock?()
}
}

/// Ensure that the `context`'s concurrency type is not `confinementConcurrencyType`, since it will crash if `perform` or `performAndWait` is called.
guard context.concurrencyType == .mainQueueConcurrencyType || context.concurrencyType == .privateQueueConcurrencyType else {
Copy link
Contributor Author

@dvdchr dvdchr Dec 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do if context.concurrencyType == .confinementConcurrencyType {, but Xcode will throw out a warning if we type a deprecated enum value. 🙃

block()
return
}

if wait {
context.performAndWait(block)
} else {
Expand Down