Skip to content

Conversation

@twstokes
Copy link
Contributor

@twstokes twstokes commented Dec 16, 2022

Part of #19448

Description

  • Adds the Jetpack banner to the Jetpack Backups view in the WordPress app.
  • Adds a new analytics event for the Jetpack Backups view.
My Site Jetpack Backups
image image

Testing

Prerequisite: Access to a site that has Jetpack Backups enabled. The WordPress.com Business and eCommerce plans both include this feature.

Banner appears in WordPress

  1. Load the WordPress app.
  2. From My Site, tap Backup in the Jetpack section.
  3. Expect: The Jetpack banner to appear at the bottom of the screen.
  4. Expect: Tapping on the Jetpack banner shows the Jetpack overlay.
  5. Expect: The event 🔵 Tracked: jetpack_powered_banner_tapped <screen: backup> to be fired.

Banner does not appear in Jetpack

  1. Load the Jetpack app.
  2. From My Site, tap Backup in the Jetpack section.
  3. Expect: No Jetpack banner to be shown.

Banner visibility behavior

  • Initially the banner should be shown when the screen appears.
  • Scrolling down hides the banner and the banner reappears only when the view is scrolled to the top.
  • If there isn't enough content to scroll, the banner doesn't show / hide on scroll.

Items to test:

  • Light / Dark mode
  • Dynamic Type / a11y
  • Different screen orientations
  • iPhone / iPad

Regression Notes

  1. Potential unintended areas of impact

    • Functionality of the Jetpack Backups page.
    • Functionality of tapping on the Jetpack banner and viewing the Jetpack overlay.
    • It's supposed to be possible to get a notification related to backups but I didn't simulate this for testing. Maybe it happens after a restore takes place?
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual tests.
  3. What automated tests I added (or what prevented me from doing so)

    • None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes twstokes added this to the 21.5 milestone Dec 16, 2022
@twstokes twstokes self-assigned this Dec 16, 2022
@twstokes twstokes force-pushed the task/backups-jp-banner branch from 7876b10 to 9a43350 Compare December 16, 2022 00:43
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 16, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19784-1de08a2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 16, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19784-1de08a2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@twstokes twstokes force-pushed the task/backups-jp-banner branch from 9a43350 to 1064f40 Compare December 20, 2022 01:57
@twstokes twstokes marked this pull request as ready for review December 20, 2022 23:22
Copy link
Contributor

@hassaanelgarem hassaanelgarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 🚀

It's supposed to be possible to get a notification related to backups but I didn't simulate this for testing. Maybe it happens after a restore takes place?

I simulated this by tweaking the code a little to forcefully trigger this action and it works as expected 👍

@twstokes twstokes merged commit 5a7fec2 into trunk Jan 4, 2023
@twstokes twstokes deleted the task/backups-jp-banner branch January 4, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants