Skip to content

[Stats Revamp] Remove "Comments" card from revamped Stats #19830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2023
Merged

[Stats Revamp] Remove "Comments" card from revamped Stats #19830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fc438e
Only show supported insights in Stats Insights tab
staskus Jan 3, 2023
8ab1e6e
Use only a single definition of allInsights defined in StatSection
staskus Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions WordPress/Classes/ViewRelated/Stats/Helpers/StatSection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,21 @@

static var allInsights: [StatSection] {
if FeatureFlag.statsNewInsights.enabled {
return [StatSection.insightsViewsVisitors,
.insightsLatestPostSummary,
.insightsAllTime,
return [.insightsViewsVisitors,
.insightsLikesTotals,
.insightsCommentsTotals,
.insightsFollowerTotals,
.insightsMostPopularTime,
.insightsTagsAndCategories,
.insightsLatestPostSummary,
.insightsAllTime,
.insightsAnnualSiteStats,
.insightsCommentsAuthors,
.insightsCommentsPosts,
.insightsFollowersWordPress,
.insightsFollowersEmail,
.insightsTodaysStats,
.insightsPostingActivity,
.insightsTagsAndCategories,
.insightsFollowersEmail,
.insightsPublicize]
} else {
return [StatSection.insightsLatestPostSummary,
return [.insightsLatestPostSummary,
.insightsAllTime,
.insightsFollowerTotals,
.insightsMostPopularTime,
Expand Down
18 changes: 1 addition & 17 deletions ...ses/ViewRelated/Stats/Insights/Insights Management/InsightsManagementViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class InsightsManagementViewController: UITableViewController {
}

private var insightsInactive: [StatSection] {
InsightsManagementViewController.allInsights.filter({ !self.insightsShown.contains($0) })
StatSection.allInsights.filter({ !self.insightsShown.contains($0) })
}

private var hasChanges: Bool {
Expand Down Expand Up @@ -388,22 +388,6 @@ private extension InsightsManagementViewController {
action: nil)
}

private static let allInsights: [StatSection] = [
.insightsViewsVisitors,
.insightsLikesTotals,
.insightsCommentsTotals,
.insightsFollowerTotals,
.insightsMostPopularTime,
.insightsLatestPostSummary,
.insightsAllTime,
.insightsAnnualSiteStats,
.insightsTodaysStats,
.insightsPostingActivity,
.insightsTagsAndCategories,
.insightsFollowersEmail,
.insightsPublicize
]

// MARK: - Insights Categories

enum InsightsCategories {
Expand Down
1 change: 1 addition & 0 deletions WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class SiteStatsInsightsTableViewController: SiteStatsBaseTableViewController, St
private var insightsToShow: [InsightType] {
get {
SiteStatsInformation.sharedInstance.getCurrentSiteInsights()
.filter(StatSection.allInsights.compactMap(\.insightType).contains)
}

set {
Expand Down