[Stats Revamp] Remove "Comments" card from revamped Stats

[staskus]

Description

"Comments" card should not appear after Stats Revamp is enabled. Filter it out from visible insights.

Testing instructions

Case 1:

1. Disable "New Appearance for Stats" and "New Cards for Stats Insights" feature flags
2. Open Stats
3. Add "Comments" card
4. Enable "New Appearance for Stats" and "New Cards for Stats Insights" feature flags
5. Come back to Stats
6. "Comments" card should not be visible
7. Click gear icon on top right
8. "Comments" row should not be visible as well

Regression Notes

1. Potential unintended areas of impact

Make sure "Comments" continues to be visible when feature flag is disabled, make sure other cards appear when Stats Revamp is enabled

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

3. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Images & Videos

Before the fix

Top.Commenters.-.Before.the.fix.mov

After the fix

Top.Commenters.-.After.the.fix.mp4

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19830-8ab1e6e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19830-8ab1e6e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[sla8c]

@staskus It took me sometime to sketch out what has changed here so I thought it was best to diagram. On testing, I haven't run into any issues with removing .insightsFollowersWordPress but I just wanted to check whether this was intentional to remove it but specifically keep .insightsFollowersEmail?

[staskus]

@staskus It took me sometime to sketch out what has changed here so I thought it was best to diagram. On testing, I haven't run into any issues with removing .insightsFollowersWordPress but I just wanted to check whether this was intentional to remove it but specifically keep .insightsFollowersEmail?

@sla8c, thanks for carefully taking a look.

For both older and revamped stats, we only show .insightsFollowersEmail which displays both WordPressand Emailfollowers. The same is for insightsCommentsPostsin the older stats where we allow to switch between authorsand posts (See InsightsManagementViewController.insights)

I didn't come up with this list myself, the changes you are looking at are copy-pasted from InsightsManagementViewController so we wouldn't have 2 places defining new set of stats.