Skip to content

Jetpack Focus: Correctly configure learn more buttons #19907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 15, 2023
Merged

Jetpack Focus: Correctly configure learn more buttons #19907

merged 4 commits into from
Jan 15, 2023

Conversation

@hassaanelgarem
Copy link
Contributor

@hassaanelgarem hassaanelgarem commented Jan 13, 2023

Ref: p1673545326946679-slack-C04564QS0V7

Description

This PR does two things:

  • Removes the learn more button from the self-hosted and new-users overlays.
  • Makes tapping the learn more button of the menu card open up the overlay instead of opening up a link.

Testing Instructions

Phase 3

  1. Run the app
  2. Open the debug menu and enable "Jetpack Features Removal Phase Three"
  3. Navigate to My Site
  4. Tap on the learn more button in the card
  5. Make sure the overlay is displayed
  6. Make sure the overlay contains a learn more button

New Users

  1. Run the app
  2. Open the debug menu and enable "Jetpack Features Removal For New Users"
  3. Navigate to My Site
  4. Tap on the learn more button in the card
  5. Make sure the overlay is displayed
  6. Make sure the overlay does not contain a learn more button

Self-Hosted

  1. Run the app
  2. Open the debug menu and enable "Jetpack Features Removal For Self-Hosted Sites"
  3. Navigate to My Site
  4. Tap on the learn more button in the card
  5. Make sure the overlay is displayed
  6. Make sure the overlay does not contain a learn more button

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added this to the 21.6 milestone Jan 13, 2023
@hassaanelgarem hassaanelgarem self-assigned this Jan 13, 2023
@hassaanelgarem hassaanelgarem mentioned this pull request Jan 13, 2023
Merged
4 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 13, 2023 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19907-8fffe61 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

momo-ozawa
momo-ozawa approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 13, 2023 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19907-8fffe61 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@hassaanelgarem
Merge branch 'task/19592-self-hosted-phase' into task/19592-remove-le…
8fffe61 
…arn-more

# Conflicts:
#	WordPress/WordPressTest/JetpackBrandingMenuCardPresenterTests.swift
Base automatically changed from task/19592-self-hosted-phase to trunk January 15, 2023 21:04
@hassaanelgarem hassaanelgarem merged commit 5a8acf7 into trunk Jan 15, 2023
@hassaanelgarem hassaanelgarem deleted the task/19592-remove-learn-more branch January 15, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hassaanelgarem hassaanelgarem

Labels

[Type] Bug

Projects

None yet

Milestone

21.6

Development

Successfully merging this pull request may close these issues.

4 participants

@hassaanelgarem @wpmobilebot @momo-ozawa