-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[UI Test] Removed tabBar init from redesigned Domains Suggestions Screen
#20752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20752-2fa6061 | |
| Version | 22.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 2fa6061 | |
| App Center Build | WPiOS - One-Offs #5792 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20752-2fa6061 | |
| Version | 22.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 2fa6061 | |
| App Center Build | jetpack-installable-builds #4822 |
guarani
approved these changes
May 29, 2023
Contributor
guarani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiagomar
approved these changes
May 29, 2023
Contributor
tiagomar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine locally and in CI. Also approving it, 2 > 1. =]
Contributor
|
Taking over merging so that |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
#20728 updates
testFreeToPaidCardNavigationUI test, and includes an assertion for the screen that looked like this:However, before #20728 was merged, another PR #20731 that redesigns this screen was merged to
trunk:As can be seen, the newer design uses an overlay style and makes the bottom navigation bar overlapped. Once #20728 was merged to
trunktoo, the test began to fail consistently, becauseDomainsSuggestionsScreenwas initializing thetabBar, which no longer was visible in the app. The PR simply removestabBarfrom screeninit.To test