Skip to content

Conversation

@pachlava
Copy link
Contributor

@pachlava pachlava commented May 29, 2023

Description

#20728 updates testFreeToPaidCardNavigation UI test, and includes an assertion for the screen that looked like this:

Screenshot 2023-05-29 at 16 59 04

However, before #20728 was merged, another PR #20731 that redesigns this screen was merged to trunk:

Screenshot 2023-05-29 at 16 59 45

As can be seen, the newer design uses an overlay style and makes the bottom navigation bar overlapped. Once #20728 was merged to trunk too, the test began to fail consistently, because DomainsSuggestionsScreen was initializing the tabBar, which no longer was visible in the app. The PR simply removes tabBar from screen init.

To test

  • CI is green.

@pachlava pachlava requested a review from a team as a code owner May 29, 2023 09:56
@pachlava pachlava marked this pull request as draft May 29, 2023 09:56
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 29, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20752-2fa6061
Version22.4
Bundle IDorg.wordpress.alpha
Commit2fa6061
App Center BuildWPiOS - One-Offs #5792
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 29, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20752-2fa6061
Version22.4
Bundle IDcom.jetpack.alpha
Commit2fa6061
App Center Buildjetpack-installable-builds #4822
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pachlava pachlava added the Testing Unit and UI Tests and Tooling label May 29, 2023
@pachlava pachlava added this to the Someday milestone May 29, 2023
@pachlava pachlava marked this pull request as ready for review May 29, 2023 14:05
@pachlava pachlava requested review from jostnes, staskus and tiagomar May 29, 2023 14:05
@guarani guarani self-requested a review May 29, 2023 16:58
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on behalf of @staskus who's away today.
I ran just testFreeToPaidCardNavigation locally on iPhone and iPad and they both passed. The removal of tabBar looks good because of the recent changes to the domains screen.

Thanks a lot for making this change, @pachlava!

Copy link
Contributor

@tiagomar tiagomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working fine locally and in CI. Also approving it, 2 > 1. =]

@mokagio
Copy link
Contributor

mokagio commented May 29, 2023

Taking over merging so that trunk returns stable. Thank you @pachlava!

@mokagio mokagio merged commit 03f5d70 into trunk May 30, 2023
@mokagio mokagio deleted the fix-testFreeToPaidCardNavigation branch May 30, 2023 00:28
@mokagio mokagio mentioned this pull request May 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants