Skip to content

Conversation

@tiagomar
Copy link
Contributor

@tiagomar tiagomar commented Jul 8, 2023

Description

The objective of this PR is to disable Auto Fill Passwords under Settings for UI Tests to avoid the burden of dealing with the Save Password prompt, which is handled now in regular runs but it's heavily impacted by the long delays during Login perceived in CI (analysis available below).

iPad FAIL/PASS analysis image
iPhone FAIL/PASS analysis image

Testing

  • UI Test steps in CI should be 🟢.

@tiagomar tiagomar added the Testing Unit and UI Tests and Tooling label Jul 8, 2023
@tiagomar tiagomar added this to the Someday milestone Jul 8, 2023
@tiagomar tiagomar mentioned this pull request Jul 8, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 8, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21034-628f6e9
Version22.7
Bundle IDorg.wordpress.alpha
Commit628f6e9
App Center BuildWPiOS - One-Offs #6327
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 8, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21034-628f6e9
Version22.7
Bundle IDcom.jetpack.alpha
Commit628f6e9
App Center Buildjetpack-installable-builds #5354
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@tiagomar tiagomar marked this pull request as ready for review July 12, 2023 14:54
@tiagomar tiagomar requested a review from a team as a code owner July 12, 2023 14:54
Copy link
Contributor

@jostnes jostnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @tiagomar! Tested it out locally, and it works as described.

While this still depends on UI interaction (I know you're working on a V2, super looking forward to that!), this is an improvement to the current implementation where we anticipate and wait to dismiss the pop-up on multiple screens. :shipit:

@jostnes jostnes merged commit cd712e3 into trunk Jul 13, 2023
@jostnes jostnes deleted the ui-tests-fix-save-password-prompt branch July 13, 2023 02:52
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this @tiagomar !

It's a neater solution than my previous patch to conditionally dismiss the prompt. It should also remove the delay introduced by checking for the prompt every time.

  • Have you considered implementing the function at the UITestsFoundation framework level? That would automatically ensure both UI tests targets have access to it, regardless of what will happen to the target membership of UITests/Utils/XCTest+Extensions.swift
  • I wish there was a "before all test cases" where we could put this call, as I think it's should be required only once (unless we reset the Simulator between tests, which I don't believe we do). NSPrincipalClass might be a promising avenue.

@tiagomar
Copy link
Contributor Author

Thanks for checking and commenting, @mokagio! Especially for the nice tip around NSPrincipalClass.

I have this draft PR (still waiting for the tests to run in CI) that addresses both points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants