Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Oct 28, 2024

Fixes #23620

Screenshot 2024-10-28 at 12 14 08 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Comments label Oct 28, 2024
@kean kean requested review from crazytonyli and jkmassel October 28, 2024 16:15
views:views]];

[NSLayoutConstraint activateConstraints:@[
[self.replyTextView.leadingAnchor constraintEqualToAnchor:self.replyTextView.leadingAnchor],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was the root cause.

@kean kean added this to the Pending milestone Oct 28, 2024
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23710-2a8f46a
Version25.4.1
Bundle IDorg.wordpress.alpha
Commit2a8f46a
App Center BuildWPiOS - One-Offs #10876
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23710-2a8f46a
Version25.4.1
Bundle IDcom.jetpack.alpha
Commit2a8f46a
App Center Buildjetpack-installable-builds #9917
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean modified the milestones: Pending, 25.5 Oct 28, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@kean kean enabled auto-merge October 28, 2024 21:08
@kean kean disabled auto-merge October 29, 2024 13:22
@kean kean enabled auto-merge October 29, 2024 13:22
@kean kean disabled auto-merge October 29, 2024 23:13
@kean kean merged commit f276571 into trunk Oct 29, 2024
28 checks passed
@kean kean deleted the fix/reply-button-hidden branch October 29, 2024 23:19
@kean kean mentioned this pull request Oct 30, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to reply and comment

5 participants