Adds nullability information to Blog.h #5325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds nullability information to
Blog.h, in order to make sure that we're correctly treating access to its properties and methods.Details:
When accessing Objective-C properties, parameters and return values that don't have nullability information available from Swift code, Xcode assumes those methods and properties to be IUOs. In fact we can treat them as both optionals or non-optionals and Xcode will not give any warning to us about their usage.
This is dangerous, and this PR aims to provide Xcode with more information so that it will treat these properties, params and return values as either optionals or non-optionals.
What's inside the scope of this PR:
Blog.h.What's NOT inside the scope of this PR:
Changes:
Blog.h. All properties were markednullable, while methods were analyzed case-by-case.Test:
Needs review: @SergioEstevao