Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Nov 21, 2022

This addresses a build failure on trunk which we missed because we don't have a requirement to keep PR up-to-date with trunk before merging (unless there are conflicts, of course).

See https://buildkite.com/automattic/wordpress-authenticator-ios/builds/436, #698, and #703.

The rare fix like this is in my opinion worth the smoother developer experience the rest of the time.

This PR changes no code and addresses an issue for which CI is the only kind of verification we need. I'll admin-merge this as soon as CI is green (there's an incident currently on).


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

This addresses a build failure on `trunk` which we missed because we
don't have a requirement to keep PR up-to-date with `trunk` before
merging (unless there are conflicts, of course).

The rare fix like this is in my opinion worth the smoother developer
experience the rest of the time.
@mokagio mokagio merged commit 61c0533 into trunk Nov 22, 2022
@mokagio mokagio deleted the mokagio/fix-podfile-lock branch November 22, 2022 07:19
@crazytonyli crazytonyli mentioned this pull request Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants