canton: condense verbose module/choice doc comments#44
Merged
bengtlofgren merged 1 commit intoJul 16, 2026
Conversation
Comment-only pass across canton/core and canton/test: the module and choice-level doc comments had grown into multi-paragraph essays with ALL-CAPS section labels and repeated restatements of the same point. Tighten them to a sentence or short paragraph per fact, dropping narrative padding while keeping every load-bearing invariant, security rationale, and cross-reference intact (verified: every changed line is either a full comment line or a trailing comment on an otherwise-unchanged code line). Claude-Session: https://claude.ai/code/session_01VFr5RtBKysvjdRN2nKmhMV
3 tasks
bengtlofgren
added a commit
that referenced
this pull request
Jul 16, 2026
…ew) (#45) #41 merged directly without going through PR review. Reverting the functional changes (the GetGuardianGovernance choice, the guardianGovernance field on Emitter/EmitterRegistry/ReplayRootRegistry, the pin assertions at the three fee-charging call sites, and the 3 regression tests proving them) so the fix can go through proper review this time. Deliberately does NOT touch #44 (comment cleanup) or anything else merged since -- only the functional pieces #41 introduced, hand-picked out of the current tree so #44's independent comment tightening survives untouched in the same files. Verified: dpm build clean, 41/41 tests passing (44 minus the 3 regression tests testing now-reverted functionality). A follow-up PR (the literal git revert of this commit) will re-propose adding this back, for review this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canton/coreandcanton/test. Docs had grown into multi-paragraph essays with ALL-CAPS section labels and repeated restatements; this tightens each to a sentence or short paragraph per fact, dropping narrative padding while keeping every load-bearing invariant, security rationale, and cross-reference intact.a67cb8227); this branch is rebased directly ontointegration/canton. (Replaces canton: condense verbose module/choice doc comments #43, which GitHub auto-closed when canton: pin guardianGovernance on fee-charging CoreState references #41's merge deleted its old base branch — same content, rebuilt/retested green after the rebase.)Judgment calls worth a second look
GetGuardianGovernance's doc comment, dropped the incidental "...and an attacker guardian set" clause describing a forged CoreState -- the security point (gg is unforgeable) is preserved, just flagging the specific phrasing changed.CoreState's trailing field comments as fair game to tighten, not just the leading-- |block docs -- if you'd rather those stay verbatim, easy to revert just those hunks.Governance.daml,VAA.daml,GuardianSet.daml, and README §10/§4.6 untouched -- already tight or judged too load-bearing/fact-dense to compress further without risk.Test plan
git difffiltered for non-comment changes: none found)dpm buildclean on both packagesdpm test: 44/44 passing (rebuilt after rebasing onto the mergedintegration/cantontip)https://claude.ai/code/session_01VFr5RtBKysvjdRN2nKmhMV