canton: revert guardianGovernance fee-pin functional changes (re-review)#45
Merged
bengtlofgren merged 1 commit intoJul 16, 2026
Merged
Conversation
#41 merged directly without going through PR review. Reverting the functional changes (the GetGuardianGovernance choice, the guardianGovernance field on Emitter/EmitterRegistry/ReplayRootRegistry, the pin assertions at the three fee-charging call sites, and the 3 regression tests proving them) so the fix can go through proper review this time. Deliberately does NOT touch #44 (comment cleanup) or anything else merged since -- only the functional pieces #41 introduced, hand-picked out of the current tree so #44's independent comment tightening survives untouched in the same files. Verified: dpm build clean, 41/41 tests passing (44 minus the 3 regression tests testing now-reverted functionality). A follow-up PR (the literal git revert of this commit) will re-propose adding this back, for review this time.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#41 merged directly without going through review. This surgically reverts just its functional changes:
GetGuardianGovernancechoice onCoreState.guardianGovernancefield onEmitter/EmitterRegistry/ReplayRootRegistry.PublishMessage,RegisterEmitter,ClaimReplayRoot).Deliberately does not touch #44 (comment-density cleanup) or anything else merged since — every other line #44 tightened in these same files is untouched. A plain
git revertof #41 wasn't usable here since #44 rewrote overlapping comments afterward; this is a hand-picked inverse of just the functional pieces, verified against the original #41 diff file by file.Why
Not a rejection of the fix — it's a real, already-verified security improvement (closes a shadow-
CoreStatefee-redirect path). It just went in without the normal review step, and should get one before being final. A follow-up PR (the literalgit revertof this commit's squash) will re-propose adding it back, ready for that review.Test plan
dpm buildclean on both packagesdpm test: 41/41 passing (44 minus the 3 regression tests for now-reverted functionality)GetGuardianGovernance/functionalguardianGovernance-pin remnants anywhere in the tree (grep -rnclean)https://claude.ai/code/session_01VFr5RtBKysvjdRN2nKmhMV